Uh oh!
There was an error while loading. Please reload this page.
gh-85453: Improve instance attributes mark up on datetime.rst - #123655
Merged
Conversation
uatach
commented
Sep 3, 2024
ContributorAuthor
@erlend-aasland, I don't know how do add you as reviewer |
hugovk
reviewed
Sep 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
approved these changes
Sep 4, 2024
hugovk
left a comment
Member
There was a problem hiding this comment.
Thanks!
Nice that these are now linkable, like https://cpython-previews--123655.org.readthedocs.build/en/123655/library/datetime.html#datetime.timedelta.days
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 5, 2024
…ythonGH-123655) (cherry picked from commit 9aea9c1) Co-authored-by: edson duarte <eduarte.uatach@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-123740 is a backport of this pull request to the 3.13 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 5, 2024
…ythonGH-123655) (cherry picked from commit 9aea9c1) Co-authored-by: edson duarte <eduarte.uatach@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-123741 is a backport of this pull request to the 3.12 branch. |
hugovk added a commit
that referenced
this pull request
Sep 5, 2024
hugovk added a commit
that referenced
this pull request
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another pull request based on PR #21447, this one focused on improving instance attributes mark up.
📚 Documentation preview 📚: https://cpython-previews--123655.org.readthedocs.build/