Skip to content

gh-123290: fix reference leaks in the error-branches of _cursesmodule.c - #123953

Merged
vstinner merged 6 commits into
python:mainfrom
picnixz:curses/fix-refleaks-123290
Sep 11, 2024
Merged

gh-123290: fix reference leaks in the error-branches of _cursesmodule.c#123953
vstinner merged 6 commits into
python:mainfrom
picnixz:curses/fix-refleaks-123290

Conversation

@picnixz

@picnixzpicnixz commented Sep 11, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Hello again. Following Victor's suggestion and a private discussion on Discord, I split the PR once again to only focus on ref-leaks in error branches.

@picnixz
Fix reference leaks in the error-branches.
dd00a73
@picnixz
Cosmetic cleanup:
8769dae
- Remove some macros.
- Make some macros local instead.
- Do not use `error` label in `init()` function to prepare it for its conversion to `exec()`.
@picnixz
Use an internal exec() function to populate the module dictionary.
9f0bc2b
@picnixz
fixup diff
ca0391d
@bedevere-appbedevere-appBot mentioned this pull request Sep 11, 2024
Closed
vstinner
vstinner reviewed Sep 11, 2024
View reviewed changes
Comment threadModules/_cursesmodule.c Outdated
Comment threadModules/_cursesmodule.c
Comment threadModules/_cursesmodule.c Outdated
vstinner
vstinner reviewed Sep 11, 2024
View reviewed changes
Comment threadModules/_cursesmodule.c Outdated
vstinner
vstinner approved these changes Sep 11, 2024
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner enabled auto-merge (squash) September 11, 2024 15:21
@vstinner
vstinner merged commit 2938c3d into python:mainSep 11, 2024
@picnixz
picnixz deleted the curses/fix-refleaks-123290 branch September 11, 2024 15:52
@picnixzpicnixz mentioned this pull request Sep 13, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@vstinner