Uh oh!
There was an error while loading. Please reload this page.
[3.12] gh-121735: Fix module-adjacent references in zip files (gh-123037) - #124011
Merged
Conversation
jaracoforce-pushed
the
backport-ba687d9-3.12
branch
from
September 12, 2024 15:24
9712573 to
2d64973Comparejaraco
marked this pull request as draft
September 12, 2024 15:42
jaraco
commented
Sep 12, 2024
MemberAuthor
That's weird. The tests are failing in CI, but they're passing for me locally. I wonder why that is. |
jaraco
commented
Sep 12, 2024
MemberAuthor
The issue was twofold:
Rebuilding cpython from scratch allowed the issue to replicate. |
Applying the fix only and not the refactoring of the test suite.
jaracoforce-pushed
the
backport-ba687d9-3.12
branch
from
September 12, 2024 18:07
2d64973 to
b0b7da1Comparejaraco
marked this pull request as ready for review
September 12, 2024 18:08
jaraco
requested review from
brettcannon, encukou, ericsnowcurrently and ncoghlan
as code ownersSeptember 12, 2024 18:08
jaraco
removed request for
brettcannon, encukou, ericsnowcurrently and ncoghlanSeptember 12, 2024 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a selective backport of gh-123037, pulling only the fix and a one-off test to protect the behavior, but avoiding the test suite refactoring (which could not be backported as it also relies on other features only in Python 3.13).