Uh oh!
There was an error while loading. Please reload this page.
gh-123923: Defer refcounting for f_funcobj in _PyInterpreterFrame - #124026
Merged
Conversation
…Frame` Use a `_PyStackRef` and defer the reference to `f_funcobj` when possible. This avoids some reference count contention in the common case of executing the same code object from multiple threads concurrently in the free-threaded build.
bedevere-bot
commented
Sep 12, 2024
🤖 New build scheduled with the buildbot fleet by @colesbury for commit db12634 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
colesbury
marked this pull request as ready for review
September 12, 2024 22:49
colesbury
requested review from
Fidget-Spinner, ericsnowcurrently and markshannon
as code ownersSeptember 12, 2024 22:49
colesbury
commented
Sep 12, 2024
| target = uop.deferred_refs[tkn] | ||
| if target is None: | ||
| # An assignment we don't handle, such as to a pointer or array. | ||
| self.out.emit(tkn) |
ContributorAuthor
There was a problem hiding this comment.
This change seemed to fix some duplicate ;; in generated_cases.c.h
bedevere-bot
commented
Sep 14, 2024
🤖 New build scheduled with the buildbot fleet by @colesbury for commit cd3d83d 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Fidget-Spinner
approved these changes
Sep 17, 2024
colesbury
enabled auto-merge (squash)
September 20, 2024 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a
_PyStackRefand defer the reference tof_funcobjwhen possible. This avoids some reference count contention in the common case of executing the same code object from multiple threads concurrently in the free-threaded build._PyInterpreterFramefields #123923