Uh oh!
There was an error while loading. Please reload this page.
bpo-36345: Doc: make serve uses http.server instead of Tools/scripts/server.py - #12408
bpo-36345: Doc: make serve uses http.server instead of Tools/scripts/server.py #12408matrixise wants to merge 1 commit into
Conversation
@JulienPalard here is the PR where we deprecate |
JulienPalard
commented
Mar 18, 2019
@vstinner should we write a version of Python in which this file should be removed in the message? This is not really a module, I don't think we should follow PEP 4, but I'd like to remove it slowly just in case someone found the file and though "hey let's use it!" @matrixise You have forgotten to remove serve.py from the Tools README, and to update make.bat. |
bedevere-bot
commented
Mar 18, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
matrixise
commented
Mar 23, 2019
I have made the requested changes; please review again |
bedevere-bot
commented
Mar 23, 2019
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
vstinner
commented
Mar 23, 2019
matrixise
commented
Mar 23, 2019
I have made the requested changes; please review again |
bedevere-bot
commented
Mar 23, 2019
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
matrixise
commented
Mar 23, 2019
I added this PR #12511 |
matrixise
commented
Mar 24, 2019
bedevere-bot
commented
Mar 24, 2019
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
There was a problem hiding this comment.
What does "use http.server"? You should mention "make server" somewhere.
matrixise
commented
Mar 25, 2019
Hi @vstinner thank you for your review I have made the requested changes; please review again |
bedevere-bot
commented
Mar 25, 2019
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
vstinner
commented
Mar 26, 2019
Please squash your commits into a single commit and update the PR title and description. It became very unclear what is the purpose of this change, because of its long history. |
hugovk
commented
Nov 18, 2024
|
https://bugs.python.org/issue36345