Skip to content

gh-102511: Change the os.path.splitroot param name from path back to p - #124097

Merged
zooba merged 1 commit into
python:mainfrom
sobolevn:issue-102511-param-name
Sep 18, 2024
Merged

gh-102511: Change the os.path.splitroot param name from path back to p#124097
zooba merged 1 commit into
python:mainfrom
sobolevn:issue-102511-param-name

Conversation

@sobolevn

@sobolevnsobolevn commented Sep 15, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Refs #118089

CC @nineteendo

Now it is in sync with the Python version here:

@bedevere-appbedevere-appBot mentioned this pull request Sep 15, 2024
Closed
@nineteendo

nineteendo commented Sep 15, 2024

Copy link
Copy Markdown
Contributor

Thanks, I didn't notice this. I was too focused on the difficult aspects of the PR.

@zooba
zooba merged commit 3b6bfa7 into python:mainSep 18, 2024
@miss-islington-app

miss-islington-appBot commented Sep 18, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Sep 18, 2024

Copy link
Copy Markdown

Sorry, @sobolevn and @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3b6bfa77aa4da2ce1f3a15e39831f8b85882698c 3.13

@zooba

zooba commented Sep 18, 2024

Copy link
Copy Markdown
Member

Backport should wait for 3.13.1 anyway, so we'll rebase it then.

@zwarezware mentioned this pull request Sep 18, 2024
Merged
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@sobolevn@savannahostrowski
pythongh-102511: Change theos.path.splitrootparam name from `path…
3c9475b
…` back to `p` (pythonGH-124097)
@bedevere-app

bedevere-appBot commented Oct 3, 2024

Copy link
Copy Markdown

GH-124919 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Oct 3, 2024
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Oct 3, 2024
@sobolevn@JelleZijlstra
[3.13]pythongh-102511: Change theos.path.splitrootparam name fro…
8a0285b
…m `path` back to `p` (pythonGH-124097)
(cherry picked from commit 3b6bfa7)
Co-authored-by: sobolevn <mail@sobolevn.me>
@JelleZijlstra

JelleZijlstra commented Oct 3, 2024

Copy link
Copy Markdown
Member

I opened the backport PR just so this doesn't get lost, the conflict was in clinic output only.

JelleZijlstra added a commit that referenced this pull request Oct 8, 2024
@JelleZijlstra@sobolevn
[3.13]gh-102511: Change theos.path.splitrootparam name from `pat…
761c3b2
…h` back to `p` (GH-124097) (#124919)
(cherry picked from commit 3b6bfa7)
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes
@barneygalebarneygaleAwaiting requested review from barneygale
@hugovkhugovkAwaiting requested review from hugovk
@zoobazoobaAwaiting requested review from zooba

Assignees

@zoobazooba

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn@nineteendo@zooba@JelleZijlstra@picnixz