Uh oh!
There was an error while loading. Please reload this page.
gh-124153: Implement PyType_GetBaseByToken() and Py_tp_token slot - #124163
Conversation
neonene
commented
Sep 17, 2024
I'll check this and PoC version again. |
encukou
left a comment
There was a problem hiding this comment.
Looks great, thank you!
I have just one style suggestion. But if you'd like to keep it we can merge the PR as it is.
Uh oh!
There was an error while loading. Please reload this page.
| return -1; | ||
| } | ||
| if (!_PyType_HasFeature(type, Py_TPFLAGS_HEAPTYPE)) { |
There was a problem hiding this comment.
When I observed a good performance, the line had a typo (missing a NOT), though check_base_by_token() was unused during a PGO test. The telco got slower by 5-10% once I corrected, which was actually fixed by one of the following:
Use
if-elsestatementReplace
_PyType_HasFeature()with the publicPyType_HasFeature(), not with ineffective(type->tp_flags & Py_TPFLAGS_HEAPTYPE)
They are not used in PyType_GetBaseByToken().
This chains the branches in PyType_GetBaseByToken() as well, which is effective when MSVC is in better condition on PGO.
neonene
commented
Sep 18, 2024
I think I've finished. When checking a type without a result, this may be a bit slower than the draft PR, not trained well for now. |
PyType_GetBaseByTokenfunction withPy_tp_tokenslot #124153📚 Documentation preview 📚: https://cpython-previews--124163.org.readthedocs.build/