gh-124153: Remove _PyType_GetModuleByDef2 private function

[neonene]

• Issue: Add PyType_GetBaseByToken function with Py_tp_token slot #124153

[encukou]

Looks like this removes the only call to _PyType_GetModuleByDef2; could you also remove the function?

[vstinner]

Looks like this removes the only call to _PyType_GetModuleByDef2; could you also remove the function?

@neonene prepared #124262 but this follow-up PR cannot be merged before the code is updated to no longer call _PyType_GetModuleByDef2 ;-)

[neonene]

@neonene prepared #124262 but this follow-up PR cannot be merged before the code is updated to no longer call _PyType_GetModuleByDef2 ;-)

I've port the header update from #124262 to here. Is this what you mean?

[vstinner]

Why not removing _PyType_GetModuleByDef2() body as well?

[neonene]

(Does it really make sense to remove _PyType_GetModuleByDef2() before checking the features on main?)

[encukou]

To be honest I don't follow too closely the order in which the changes here should be made/merged.
I also have no way to benchmark with MSVC, so I trust you about the performance, and just review for functionality and readability :)

If this removes the last call to _PyType_GetModuleByDef2, and we don't plan to bring the function back, then it should be removed now. If it turns out to be needed again, we can find it in Git history.

[vstinner]

LGTM