Skip to content

gh-119180: Add discussion of annotations to the 3.14 What's New - #124393

Merged
JelleZijlstra merged 5 commits into
python:mainfrom
JelleZijlstra:pep649-whatsnew
Sep 24, 2024
Merged

gh-119180: Add discussion of annotations to the 3.14 What's New#124393
JelleZijlstra merged 5 commits into
python:mainfrom
JelleZijlstra:pep649-whatsnew

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Sep 23, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot added awaiting core review docs Documentation in the Doc dir skip news labels Sep 23, 2024
@bedevere-appbedevere-appBot mentioned this pull request Sep 23, 2024
Closed
30 tasks
AlexWaygood
AlexWaygood reviewed Sep 24, 2024
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment threadDoc/whatsnew/3.14.rst
Comment on lines +84 to +88
annotations. Annotations may be evaluated in the :attr:`~annotationlib.Format.VALUE`
format (which evaluates annotations to runtime values, similar to the behavior in
earlier Python versions), the :attr:`~annotationlib.Format.FORWARDREF` format
(which replaces undefined names with special markers), and the
:attr:`~annotationlib.Format.SOURCE` format (which returns annotations as strings).

@AlexWaygoodAlexWaygoodSep 23, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will render as VALUE, FORWARDREF, SOURCE. Is that what we want, or would Format.VALUE, Format.FORWARDREF and Format.SOURCE be better?

@JelleZijlstraJelleZijlstraSep 24, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did intend these to render as VALUE etc. Do you think adding Format is better?

@AlexWaygoodAlexWaygoodSep 24, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd weakly prefer Format.VALUE, but it might make the markup quite verbose, and I don't have a strong opinion :-)

Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/whatsnew/3.14.rst
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
JelleZijlstraand others added 2 commits September 23, 2024 17:16
@JelleZijlstra@AlexWaygood
Apply suggestions from code review
697e13d
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstra
Update Doc/whatsnew/3.14.rst
8e8e45e
@AlexWaygood

AlexWaygood commented Sep 24, 2024

Copy link
Copy Markdown
Member

(As I mentioned offline, my high-level feedback would be that it would be nice to have some more positive content about the motivations and advantages of this change. Overall the tone is a bit gloomy currently -- but it's overall a great change, that we have lots of reasons for! :-D )

AlexWaygood
AlexWaygood approved these changes Sep 24, 2024
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleZijlstra
JelleZijlstra merged commit d56faf2 into python:mainSep 24, 2024
@JelleZijlstra
JelleZijlstra deleted the pep649-whatsnew branch September 24, 2024 05:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JelleZijlstra@AlexWaygood