Uh oh!
There was an error while loading. Please reload this page.
gh-124502: Add PyUnicode_Equal() function - #124504
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Sep 25, 2024
@picnixz@rruuaanng@ZeroIntensity: I addressed your comments. Please review the updated PR. |
picnixz
left a comment
There was a problem hiding this comment.
Final nitpick but you can ignore it (I don't know whether it's that useful).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rruuaanng
commented
Sep 25, 2024
Maybe you are right, But you can consider my suggestion. |
vstinner
commented
Sep 25, 2024
I created capi-workgroup/decisions#43 issue in the C API Working Group. |
I wrote a microbenchmark comparing equal strings of 10 characters: Results on Fedora 40 with CPU isolation:
Proposed public Private |
Microbenchmark on comparison of inequal strings of 10 characters, only the last character is different.
|
vstinner
commented
Oct 7, 2024
The C API Working Group approved the API. |
vstinner
commented
Oct 7, 2024
Merged. Thanks for reviews @picnixz and @ZeroIntensity. |
📚 Documentation preview 📚: https://cpython-previews--124504.org.readthedocs.build/