Uh oh!
There was an error while loading. Please reload this page.
[3.13] gh-124309: Modernize the staggered_race implementation to support eager task factories (GH-124390) - #124573
[3.13] gh-124309: Modernize the staggered_race implementation to support eager task factories (GH-124390)#124573miss-islington wants to merge 3 commits into
staggered_race implementation to support eager task factories (GH-124390)#124573Conversation
…port eager task factories (pythonGH-124390) (cherry picked from commit de929f3) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Yhg1s
commented
Sep 26, 2024
Does this need to go into 3.13.0, or can it wait until 3.13.1? |
would be good to have in 3.13.0 as loop param is now added back. |
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM, two optional nits.
I'll leave it to @Yhg1s to decide whether to include this in RC3.
| exceptions, addrinfo, laddr_infos) | ||
| for addrinfo in infos), | ||
| happy_eyeballs_delay, loop=self) | ||
| happy_eyeballs_delay) |
There was a problem hiding this comment.
I added it back but I don't think it's necessary, loop would be the running loop anyways at this point.
Uh oh!
There was an error while loading. Please reload this page.
Yhg1s
left a comment
There was a problem hiding this comment.
Is this in a state to go in now? (The branch needs updating, and I don't know if there's been any other work in main that should be reflected in this change.)
graingert
commented
Oct 31, 2024
This original PR was reverted, and this backport is no longer needed |
(cherry picked from commit de929f3)
Co-authored-by: Peter Bierma zintensitydev@gmail.com
Co-authored-by: Thomas Grainger tagrain@gmail.com
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
Co-authored-by: Carol Willing carolcode@willingconsulting.com
Co-authored-by: Kumar Aditya kumaraditya@python.org