Skip to content

gh-124102: Update internal PCbuild docs and correct WiX registry - #124784

Merged
zooba merged 6 commits into
python:mainfrom
Wulian233:pcbuild
Oct 18, 2024
Merged

gh-124102: Update internal PCbuild docs and correct WiX registry#124784
zooba merged 6 commits into
python:mainfrom
Wulian233:pcbuild

Conversation

@Wulian233

@Wulian233Wulian233 commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

skip news
@zooba I got something wrong in the previous PR

  • Corrected the incorrect information in the previous PR
2024-09-30 182656
  • Fixed the incorrect WiX 3.14 registry.

Comment threadTools/msi/wix.props Outdated
Comment threadDoc/using/windows.rst Outdated
@Wulian233
Wulian233 requested a review from zoobaOctober 4, 2024 01:38
@Wulian233

Copy link
Copy Markdown
ContributorAuthor

@zooba Could you please review this again? I have already resolved the issues mentioned :)

@Wulian233Wulian233 changed the title gh-124102: Update internal documentation under PCbuild, so it now correctly states that Windows Dependency Information gh-124102: Update internal PCbuild docs and correct WiX registryOct 14, 2024
@zooba
zooba merged commit cda0ec8 into python:mainOct 18, 2024
@Wulian233
Wulian233 deleted the pcbuild branch October 18, 2024 13:15
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Wulian233@zooba