Skip to content

[3.10] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) - #125106

Merged
pablogsal merged 2 commits into
python:3.10from
miss-islington:backport-f7bfac4-3.10
Oct 22, 2024
Merged

[3.10] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423)#125106
pablogsal merged 2 commits into
python:3.10from
miss-islington:backport-f7bfac4-3.10

Conversation

@miss-islington

Copy link
Copy Markdown
Contributor

gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423)

Use a longer key: FIPS mode requires at least of at least 112 bits.
The previous key was only 32 bits.
(cherry picked from commit e091b9f)

(cherry picked from commit f7bfac4)

Co-authored-by: Miss Islington (bot) 31488909+miss-islington@users.noreply.github.com
Co-authored-by: Victor Stinner vstinner@python.org

…pythonGH-109423) (pythonGH-109427)
pythongh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (pythonGH-109423)
Use a longer key: FIPS mode requires at least of at least 112 bits.
The previous key was only 32 bits.
(cherry picked from commit e091b9f)
(cherry picked from commit f7bfac4)
Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-appbedevere-appBot added tests Tests in the Lib/test dir awaiting review labels Oct 8, 2024
@encukouencukou changed the title [3.10] [3.11] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) (GH-109427)[3.10] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423)Oct 8, 2024
@encukou

Copy link
Copy Markdown
Member

See gh-125112 for the macOS CI failure.

@encukou
encukou marked this pull request as draft October 8, 2024 14:12
@encukou

Copy link
Copy Markdown
Member

!buildbot FIPS

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1a719bf 🤖

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR

@encukou
encukou marked this pull request as ready for review October 10, 2024 11:41
@encukou

Copy link
Copy Markdown
Member

Note that we care about Only Blake2 builds, which passed here.
The red No Builtin Hashes FIPS builds are unstable and never passed.

@pablogsal
pablogsal merged commit e44b32f into python:3.10Oct 22, 2024
@miss-islington
miss-islington deleted the backport-f7bfac4-3.10 branch January 2, 2026 18:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington@encukou@bedevere-bot@pablogsal