Skip to content

gh-125196: Use PyUnicodeWriter in symtable.c - #125199

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:symtable
Oct 9, 2024
Merged

gh-125196: Use PyUnicodeWriter in symtable.c#125199
vstinner merged 1 commit into
python:mainfrom
vstinner:symtable

Conversation

@vstinner

@vstinnervstinner commented Oct 9, 2024

Copy link
Copy Markdown
Member

@vstinner
vstinner merged commit 9bda775 into python:mainOct 9, 2024
@vstinner
vstinner deleted the symtable branch October 9, 2024 15:54
@vstinner

Copy link
Copy Markdown
MemberAuthor

Merged, thanks for the review @JelleZijlstra.

@encukou

Copy link
Copy Markdown
Member

Due to either this change or #124865, the AMD64 Arch Linux TraceRefs 3.x buildbot is failing: https://buildbot.python.org/#/builders/484/builds/6022/steps/6/logs/stdio

@vstinner

Copy link
Copy Markdown
MemberAuthor

Due to either this change or #124865, the AMD64 Arch Linux TraceRefs 3.x buildbot is failing: https://buildbot.python.org/#/builders/484/builds/6022/steps/6/logs/stdio

I checked with git bisect and the regression was introduced by commit f2cb399:

commit f2cb39947093feda3ff85b8dc820922cc5e5f954
Author: Eric Snow <ericsnowcurrently@gmail.com>
Date: Wed Oct 9 11:32:16 2024 -0600
gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (gh-124865)
Fix a crash caused by immortal interned strings being shared between
sub-interpreters that use basic single-phase init. In that case, the string
can be used by an interpreter that outlives the interpreter that created and
interned it. For interpreters that share obmalloc state, also share the
interned dict with the main interpreter.
This is an un-revert of gh-124646 that then addresses the Py_TRACE_REFS
failures identified by gh-124785.

@nascheme

Copy link
Copy Markdown
Member

I created a bug for this crash: gh-125286

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@encukou@nascheme@JelleZijlstra