Skip to content

gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash - #125218

Closed
mdboom wants to merge 4 commits into
python:mainfrom
mdboom:disable-interpreter-optimizations-when-jit-enabled
Closed

gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash#125218
mdboom wants to merge 4 commits into
python:mainfrom
mdboom:disable-interpreter-optimizations-when-jit-enabled

Conversation

@mdboom

@mdboommdboom commented Oct 9, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Oct 9, 2024
Closed
@mdboommdboom changed the title gh-125217: Turn off optimization are _PyEval_EvalFrameDefault to avoid MSVC crashgh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crashOct 9, 2024
@mdboom
mdboom marked this pull request as draft October 10, 2024 15:47
@mdboom

mdboom commented Oct 11, 2024

Copy link
Copy Markdown
ContributorAuthor

Closing is this does not resolve the issue.

@mdboommdboom closed this Oct 11, 2024
@neonene

neonene commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Have you already tried _Py_JIT (underscored)? I have an alternative, but I prefer this.

@mdboom

mdboom commented Oct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

Have you already tried _Py_JIT (underscored)? I have an alternative, but I prefer this.

Thanks, @neonene. Indeed, that was just a typo on my part and correcting it does work around the compiler crash. Github wouldn't let me re-open this but I have a new PR here: #125477

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherAwaiting requested review from brandtbucherbrandtbucher is a code owner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski will be requested when the pull request is marked ready for reviewsavannahostrowski is a code owner
@diegorussodiegorussoAwaiting requested review from diegorussodiegorusso will be requested when the pull request is marked ready for reviewdiegorusso is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdboom@neonene