Skip to content

gh-125543: Add an internal C API for dynamic arrays - #125554

Closed
ZeroIntensity wants to merge 22 commits into
python:mainfrom
ZeroIntensity:dynarray
Closed

gh-125543: Add an internal C API for dynamic arrays#125554
ZeroIntensity wants to merge 22 commits into
python:mainfrom
ZeroIntensity:dynarray

Conversation

@ZeroIntensity

@ZeroIntensityZeroIntensity commented Oct 15, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 15, 2024
Closed
Eclips4
Eclips4 reviewed Oct 15, 2024
View reviewed changes
Comment threadInclude/internal/pycore_dynarray.h
Comment threadPython/dynarray.c
@ZeroIntensity
ZeroIntensity marked this pull request as ready for review October 19, 2024 16:33
Eclips4
Eclips4 reviewed Oct 19, 2024
View reviewed changes
Comment threadPython/dynarray.c Outdated
Comment threadPython/dynarray.c Outdated
Eclips4
Eclips4 approved these changes Oct 19, 2024
View reviewed changes

@Eclips4Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation and API look good to me. Let's see what others think.

@Eclips4
Eclips4 requested a review from vstinnerOctober 19, 2024 21:17
vstinner
vstinner requested changes Oct 19, 2024
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I'm not convinced that there is a need for such API. I suggest to discuss it on the issue.

@bedevere-app

bedevere-appBot commented Oct 19, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner requested changes
@Eclips4Eclips4Eclips4 approved these changes
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

No one assigned

Labels

awaiting changesskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZeroIntensity@vstinner@Eclips4