Skip to content

gh-125588: Teach the python PEG generator the new f-string tokens - #125589

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-125588
Oct 29, 2024
Merged

gh-125588: Teach the python PEG generator the new f-string tokens#125589
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-125588

Conversation

@pablogsal

@pablogsalpablogsal commented Oct 16, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 16, 2024
Closed
@Eclips4

Eclips4 commented Oct 16, 2024

Copy link
Copy Markdown
Member

The CI is failing because it is running mypy on Python 3.11, where token.py doesn't have FSTRING_ variables. I think we should bump the Python version for this mypy workflow.

@Eclips4Eclips4 mentioned this pull request Oct 16, 2024
Merged
@Eclips4

Eclips4 commented Oct 16, 2024

Copy link
Copy Markdown
Member

I've opened a #125592 for that mypy problem.

AlexWaygood
AlexWaygood reviewed Oct 16, 2024
View reviewed changes
Comment threadTools/peg_generator/mypy.ini
@Eclips4

Eclips4 commented Oct 16, 2024

Copy link
Copy Markdown
Member

Merging main to get changes from #125592

@pablogsal
pythongh-125588: Teach the python PEG generator the new f-string tokens
3363178
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsalpablogsal added the type-bug An unexpected behavior, bug, or error label Oct 29, 2024
@pablogsal
pablogsal enabled auto-merge (squash) October 29, 2024 23:06
@pablogsal
pablogsal merged commit 9dfef4e into python:mainOct 29, 2024
@pablogsal
pablogsal deleted the gh-125588 branch October 29, 2024 23:40
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@pablogsal@picnixz
pythongh-125588: Teach the python PEG generator the new f-string toke…
2b31cb7
…ns (python#125589)
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@pablogsal@ebonnal
pythongh-125588: Teach the python PEG generator the new f-string toke…
c7212ca
…ns (python#125589)
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees

No one assigned

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal@Eclips4@AlexWaygood