Skip to content

gh-125608: Trigger dictionary watchers when inline values change - #125611

Merged
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-125608-dict-watchers
Oct 21, 2024
Merged

gh-125608: Trigger dictionary watchers when inline values change#125611
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-125608-dict-watchers

Conversation

@colesbury

@colesburycolesbury commented Oct 16, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Dictionary watchers on an object's attributes dictionary (object.__dict__) were not triggered when the managed dictionary used the object's inline values.

@colesburycolesbury added the needs backport to 3.13 bugs and security fixes label Oct 16, 2024
@bedevere-appbedevere-appBot mentioned this pull request Oct 16, 2024
Closed
@colesburycolesbury changed the title gh-125608: Trigger dictionary watchers when inline values cahngegh-125608: Trigger dictionary watchers when inline values changeOct 16, 2024
@colesbury
pythongh-125608: Trigger dictionary watchers when inline values change
28871ed
Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
@colesbury
colesburyforce-pushed the gh-125608-dict-watchers branch from 3c3f150 to 28871edCompareOctober 16, 2024 19:44
@markshannon

markshannon commented Oct 17, 2024

Copy link
Copy Markdown
Member

Looks good.
The change is not on a fast path, but might be worth benchmarking just in case.

@colesbury
colesbury marked this pull request as ready for review October 17, 2024 13:57
@colesbury

colesbury commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

Benchmark results look unchanged:
https://github.com/facebookexperimental/free-threading-benchmarking/blob/main/results/bm-20241016-3.14.0a1%2B-28871ed/bm-20241016-vultr-x86_64-colesbury-gh_125608_dict_watch-3.14.0a1%2B-28871ed-vs-base.md

@williamwen42williamwen42 mentioned this pull request Oct 17, 2024
Closed
@colesbury
colesbury merged commit 5989eb7 into python:mainOct 21, 2024
@miss-islington-app

miss-islington-appBot commented Oct 21, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury
colesbury deleted the gh-125608-dict-watchers branch October 21, 2024 12:23
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 22, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
22a6d9e
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 22, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
7a7c74f
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 22, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
679f84b
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 22, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
797aa18
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 22, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
29e9af1
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 22, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
96c3a90
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 22, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
3ebb7e4
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 22, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
293d162
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
@colesbury

colesbury commented Oct 25, 2024

Copy link
Copy Markdown
ContributorAuthor

Hmmm... Miss Islington forgot to finish the backport.

@colesburycolesbury removed the needs backport to 3.13 bugs and security fixes label Oct 25, 2024
@colesburycolesbury added the needs backport to 3.13 bugs and security fixes label Oct 25, 2024
@miss-islington-app

miss-islington-appBot commented Oct 25, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2024
@colesbury@miss-islington
pythongh-125608: Trigger dictionary watchers when inline values change (
9793b96
pythonGH-125611)
Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
(cherry picked from commit 5989eb7)
Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app

bedevere-appBot commented Oct 25, 2024

Copy link
Copy Markdown

GH-125982 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Oct 25, 2024
colesbury added a commit that referenced this pull request Oct 25, 2024
@miss-islington@colesbury
[3.13]gh-125608: Trigger dictionary watchers when inline values chan…
7b46ae9
…ge (GH-125611) (GH-125982)
Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
(cherry picked from commit 5989eb7)
Co-authored-by: Sam Gross <colesbury@gmail.com>
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 25, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
b8c7d36
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this pull request Oct 25, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
f1f1b4d
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec
[ghstack-poisoned]
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Oct 28, 2024
@williamwen42@pytorchmergebot
[dynamo] handle 3.13.0 __dict__ watcher bug (#138284)
904816d
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
Pull Request resolved: #138284
Approved by: https://github.com/jansel
ghstack dependencies: #138030
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Oct 29, 2024
@williamwen42@rahulsingh-intel
[dynamo] handle 3.13.0 __dict__ watcher bug (pytorch#138284)
32ddf67
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
Pull Request resolved: pytorch#138284
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#138030
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@williamwen42@rahulsingh-intel
[dynamo] handle 3.13.0 __dict__ watcher bug (pytorch#138284)
dc1c563
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.
This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.
Pull Request resolved: pytorch#138284
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#138030
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@colesbury@ebonnal
pythongh-125608: Trigger dictionary watchers when inline values change (
a60818a
python#125611)
Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes
@brandtbucherbrandtbucherAwaiting requested review from brandtbucher
@methanemethaneAwaiting requested review from methanemethane is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury@markshannon