Uh oh!
There was an error while loading. Please reload this page.
gh-52551: Use wcsftime() to implement time.strftime() on Windows - #125658
Conversation
| #ifdef MS_WINDOWS | ||
| /* wcsftime() doesn't format correctly time zones, see issue #10653 */ | ||
| # undef HAVE_WCSFTIME | ||
| # define HAVE_WCSFTIME |
There was a problem hiding this comment.
There are compiler warnings: 'HAVE_WCSFTIME': macro redefinition [D:\a\cpython\cpython\PCbuild_freeze_module.vcxproj]
There was a problem hiding this comment.
Oh, I did not find where it was defined in C.
vstinner
commented
Oct 18, 2024
Is #54862 issue solved on Windows? |
serhiy-storchaka
commented
Oct 18, 2024
What exactly is that issue about? I get no mojibake: >>> import time
>>> time.strftime('%Z')
'Фінляндія (літо)'
>>> time.tzname
('Фінляндія (зима)', 'Фінляндія (літо)')But it crashes on invalid format string (like |
serhiy-storchaka
commented
Oct 18, 2024
Well, this was unrelated. |
vstinner
commented
Oct 18, 2024
I changed my Windows language to French and the timezone to UTC+14, I managed to get a non-ASCII timezone name: So at least for this locale (French_France.1252), it works as expected. |
serhiy-storchaka
commented
Oct 19, 2024
Thank you for your review @vstinner. |
Uh oh!
There was an error while loading. Please reload this page.