Uh oh!
There was an error while loading. Please reload this page.
gh-119786: move interpreter doc from devguide to InternalDocs - #125715
Conversation
7148b3c to
d65ee0fCompare
willingc
left a comment
There was a problem hiding this comment.
Thanks @iritkatriel. I love that the internals docs are next to the code 😄
| Recall that the [Python Compiler](https://github.com/python/cpython/blob/main/InternalDocs/compiler.md) | ||
| produces a [`CodeObject`](https://github.com/python/cpython/blob/main/InternalDocs/code_object.md), |
There was a problem hiding this comment.
I think you might be able to get away with just this (also applies to a bunch of other links in this PR):
| Recall that the [Python Compiler](https://github.com/python/cpython/blob/main/InternalDocs/compiler.md) | |
| produces a [`CodeObject`](https://github.com/python/cpython/blob/main/InternalDocs/code_object.md), | |
| Recall that the [Python Compiler](compiler.md) produces a [`CodeObject`](code_object.md), |
There was a problem hiding this comment.
I guess I could also use relative links to the code (like ../Python/bytecodes.c).
AlexWaygood
left a comment
There was a problem hiding this comment.
Nice! A couple of minor things I spotted:
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Jacob Coffee <jacob@z7x.org> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
willingc
commented
Oct 21, 2024
🚢 |

Reorganised index:
https://github.com/python/cpython/blob/7cb14417f5609f75ab484bc81885930158317336/InternalDocs/README.md
Interpreter doc:
https://github.com/python/cpython/blob/7cb14417f5609f75ab484bc81885930158317336/InternalDocs/interpreter.md