Skip to content

gh-125916: Adapt functools.reduce() to Argument Clinic - #125999

Merged
erlend-aasland merged 18 commits into
python:mainfrom
skirpichev:reduce-to-ac
Nov 1, 2024
Merged

gh-125916: Adapt functools.reduce() to Argument Clinic#125999
erlend-aasland merged 18 commits into
python:mainfrom
skirpichev:reduce-to-ac

Conversation

@skirpichev

@skirpichevskirpichev commented Oct 26, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 26, 2024
Closed
@skirpichev

skirpichev commented Oct 26, 2024

Copy link
Copy Markdown
MemberAuthor

This coming from #125917. Red alert: to make AC happy, docstring was adjusted.

I did some benchmarks.

Details
# a.pyimportpyperffromfunctoolsimportreducef=lambdax, y: x+ylst=list(range(5))
init=123runner=pyperf.Runner()
runner.bench_func('reduce(f, lst)', reduce, f, lst)
runner.bench_func('reduce(f, lst, init)', reduce, f, lst, init)

Run e.g. with: python a.py -q -o ref.json.

with results:

Benchmarkrefpatch
reduce(f, lst)1.27 us1.19 us: 1.07x faster
reduce(f, lst, init)1.43 us1.36 us: 1.05x faster
Geometric mean(ref)1.06x faster

So, at least AC-backed argument processing offer some speedup.

@skirpichevskirpichev mentioned this pull request Oct 26, 2024
Merged
@erlend-aasland

erlend-aasland commented Oct 26, 2024

Copy link
Copy Markdown
Contributor

Thanks Sergey, I'll review this within today. Ping me tomorrow if I forget.

JelleZijlstra
JelleZijlstra reviewed Oct 26, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
serhiy-storchaka
serhiy-storchaka reviewed Oct 26, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
erlend-aasland
erlend-aasland reviewed Oct 26, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
JelleZijlstra
JelleZijlstra reviewed Oct 27, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
@skirpichev
Improve functools.reduce() docstring
a22cef9
PEP 257 says that "Multi-line docstrings consist of a summary line just
like a one-line docstring, followed by a blank line, followed by a more
elaborate description." This is also a requirement from the Argument
Clinic.
@skirpichevskirpichev mentioned this pull request Oct 27, 2024
Merged
@rhettinger
rhettinger removed their request for review October 28, 2024 01:45
skirpichevand others added 2 commits October 28, 2024 07:26
@skirpichev@erlend-aasland
Apply suggestions from code review
ea5ae96
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@skirpichev
Merge branch 'main' into reduce-docstring
c0e7786
skirpichev
skirpichev commented Oct 28, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
erlend-aasland pushed a commit that referenced this pull request Oct 29, 2024
@skirpichev
Align functools.reduce() docstring withPEP-257(#126045)
9b14083
Yak-shave in preparation for Argument Clinic adaption in gh-125999.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2024
@skirpichev@miss-islington
Align functools.reduce() docstring with PEP-257 (pythonGH-126045)
78e59af
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
(cherry picked from commit 9b14083)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@miss-islingtonmiss-islington mentioned this pull request Oct 29, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2024
@skirpichev@miss-islington
Align functools.reduce() docstring with PEP-257 (pythonGH-126045)
112730d
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
(cherry picked from commit 9b14083)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@miss-islingtonmiss-islington mentioned this pull request Oct 29, 2024
Merged
erlend-aasland pushed a commit that referenced this pull request Oct 29, 2024
@miss-islington@skirpichev
[3.13] Align functools.reduce() docstring withPEP-257(GH-126045) (#…
e7c6310
…126113)
Yak-shave in preparation for Argument Clinic adaption in gh-125999.
(cherry picked from commit 9b14083)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
erlend-aasland pushed a commit that referenced this pull request Oct 29, 2024
@miss-islington@skirpichev
[3.12] Align functools.reduce() docstring withPEP-257(GH-126045) (#…
a8472fd
…126114)
Yak-shave in preparation for Argument Clinic adaption in gh-125999.
(cherry picked from commit 9b14083)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@erlend-aaslanderlend-aasland changed the title gh-125916: convert reduce() to Argument Clinicgh-125916: Adapt functools.reduce() to Argument ClinicOct 29, 2024
skirpichevand others added 2 commits October 29, 2024 13:55
@skirpichev@JelleZijlstra
Update Modules/_functoolsmodule.c
d86570b
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@skirpichev
+1
b011243
@erlend-aasland

erlend-aasland commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

I'll give Jelle and Serhiy a chance to chime in again before landing this.

@erlend-aasland

erlend-aasland commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

I plan to land this later today (post noon ET).

serhiy-storchaka
serhiy-storchaka reviewed Nov 1, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
skirpichevand others added 2 commits November 1, 2024 18:19
@skirpichev@serhiy-storchaka
Update Modules/_functoolsmodule.c
ebed8da
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@skirpichev
+1
57f71d0
@erlend-aasland
erlend-aasland merged commit 51ef54a into python:mainNov 1, 2024
@erlend-aasland

erlend-aasland commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR, Sergey; thanks for the reviews, Jelle and Serhiy.

@skirpichev
skirpichev deleted the reduce-to-ac branch November 2, 2024 03:10
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@skirpichev@picnixz
Align functools.reduce() docstring with PEP-257 (python#126045)
5e75d4d
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@skirpichev@picnixz
pythongh-125916: Adapt functools.reduce() to Argument Clinic (python#…
a156925
…125999)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@skirpichev@ebonnal
Align functools.reduce() docstring with PEP-257 (python#126045)
c3664b4
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@skirpichev@ebonnal
pythongh-125916: Adapt functools.reduce() to Argument Clinic (python#…
14e5e9f
…125999)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments
@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev@erlend-aasland@JelleZijlstra@serhiy-storchaka