gh-126018: Avoid aborting due to unnecessary assert in sys.audit

[devdanzin]

This PR removes an assert in sysmodule.c that caused the interpreter to abort when sys.audit received a non-string as first argument.

Without this assert, the code that runs the hooks will raise an exception instead.

• Issue: sys.audit(0) aborts due to an assertion in debug build #126018

[picnixz]

This likely requires some NEWS entry, for instance:

Fix a crash in :func:`sys.audit` when passing a non-string argument.

[picnixz]

FTR: 3.12 is not affected because the assertion does not exist:

cpython/Python/sysmodule.c

Lines 499 to 514 in 67b2701

	if (!should_audit(tstate->interp)) {
	Py_RETURN_NONE;
	}
	PyObject*auditEvent=args[0];
	if (!auditEvent) {
	_PyErr_SetString(tstate, PyExc_TypeError,
	"expected str for argument 'event'");
	returnNULL;
	}
	if (!PyUnicode_Check(auditEvent)) {
	_PyErr_Format(tstate, PyExc_TypeError,
	"expected str for argument 'event', not %.200s",
	Py_TYPE(auditEvent)->tp_name);
	returnNULL;
	}

[devdanzin]

Thank you very much for the review and suggestions @picnixz and @Eclips4!

[ZeroIntensity]

This works, but I would be more comfortable just converting this to clinic.

[devdanzin]

This works, but I would be more comfortable just converting this to clinic.

I'm not too attached to this PR, but converting to AC is beyond my skills. If you or someone else wants to propose another PR with that approach, I'll gladly close this one.

[JelleZijlstra]

Converting to AC can wait for a later PR, and probably should be done only in main.

[miss-islington-app]

Thanks @devdanzin for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

[bedevere-app]

GH-126042 is a backport of this pull request to the 3.13 branch.