Skip to content

gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 - #126392

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:docs-co_lnotab-3.15
Nov 4, 2024
Merged

gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14#126392
hugovk merged 1 commit into
python:mainfrom
hugovk:docs-co_lnotab-3.15

Conversation

@hugovk

@hugovkhugovk commented Nov 4, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

There's still quite a bit of use in the wild and we're in no rush to remove this in Python 3.14.

Let's bump to 3.15 and reassess during the next cycle.

📚 Documentation preview 📚: https://cpython-previews--126392.org.readthedocs.build/

@hugovkhugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 4, 2024
@hugovk
hugovk requested a review from willingc as a code ownerNovember 4, 2024 11:10
@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news awaiting core review labels Nov 4, 2024
@hugovkhugovk changed the title gh-101866: Docs: Keep co_lnotab deprecation for at least 3.14gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14Nov 4, 2024
@bedevere-appbedevere-appBot mentioned this pull request Nov 4, 2024
Closed
AlexWaygood
AlexWaygood approved these changes Nov 4, 2024
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's unlikely this will be removed while it's still in use by pytorch, huggingface, and many others. So I'd also be okay with changing the deprecation notice to an undefined removal date for now. But at the same time, it's less likely that they'll ever remove their uses of co_lnotab unless there is a removal date, so this is also fine!

sobolevn
sobolevn approved these changes Nov 4, 2024
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukou

encukou commented Nov 4, 2024

Copy link
Copy Markdown
Member

Why not “maybe someday” rather than 3.15? To me it seems that not breaking things would save effort on both sides.

@markshannon

markshannon commented Nov 4, 2024

Copy link
Copy Markdown
Member

While we could delay this indefinitely, we should encourage users to move as sooner rather than later.

Using co_lnotab for picking is pointless as co_linetable contains all the information.
If it is being used to find line numbers, it is far more efficient to use co_lines or co_positions.

willingc
willingc approved these changes Nov 4, 2024
View reviewed changes

@willingcwillingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @hugovk. Thanks.

@hugovk

hugovk commented Nov 4, 2024

Copy link
Copy Markdown
MemberAuthor

And I the wording is now all "May be removed in ..." instead of 2x that and 1x "therefore it will be removed in ..."

@hugovk
hugovk merged commit eac41c5 into python:mainNov 4, 2024
@hugovk
hugovk deleted the docs-co_lnotab-3.15 branch November 4, 2024 16:50
@miss-islington-app

miss-islington-appBot commented Nov 4, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 4, 2024

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker eac41c5ddfadf52fbd84ee898ad56aedd5d90a41 3.13

@miss-islington-app

miss-islington-appBot commented Nov 4, 2024

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker eac41c5ddfadf52fbd84ee898ad56aedd5d90a41 3.12

hugovk added a commit to hugovk/cpython that referenced this pull request Nov 4, 2024
@hugovk
[3.13]pythongh-101865: Docs: Keep co_lnotab deprecation for at least…
5ee730c
… 3.14 (pythonGH-126392)
(cherry picked from commit eac41c5)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Nov 4, 2024

Copy link
Copy Markdown

GH-126403 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Nov 4, 2024
hugovk added a commit to hugovk/cpython that referenced this pull request Nov 4, 2024
@hugovk
[3.12]pythongh-101865: Docs: Keep co_lnotab deprecation for at least…
5e90e7f
… 3.14 (pythonGH-126392)
(cherry picked from commit eac41c5)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Nov 4, 2024

Copy link
Copy Markdown

GH-126404 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Nov 4, 2024
hugovk added a commit that referenced this pull request Nov 4, 2024
@hugovk
[3.13]gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 (G…
cccc066
…H-126392) (#126403)
(cherry picked from commit eac41c5)
hugovk added a commit that referenced this pull request Nov 4, 2024
@hugovk
[3.12]gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 (G…
94423b6
…H-126392) (#126404)
(cherry picked from commit eac41c5)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@hugovk@picnixz
pythongh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 (p…
d0fd8f0
…ython#126392)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@hugovk@ebonnal
pythongh-101865: Docs: Keep co_lnotab deprecation for at least 3.14 (p…
f24d2e6
…ython#126392)
@hugovkhugovk mentioned this pull request Mar 24, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingcwillingcwillingc approved these changes
@sobolevnsobolevnsobolevn approved these changes
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

@hugovkhugovk

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hugovk@encukou@markshannon@willingc@sobolevn@AlexWaygood