Uh oh!
There was an error while loading. Please reload this page.
gh-109413: Enable strict_optional for libregrtest/main.py - #126394
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
reviewed
Nov 7, 2024
| @property | ||
| def tmp_dir(self) -> StrPath: | ||
| assert self._tmp_dir is not None, ( |
Member
There was a problem hiding this comment.
Please replace asssert with if+raise.
Uh oh!
There was an error while loading. Please reload this page.
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @sobolevn, I could not cleanly backport this to |
sobolevn
commented
Nov 13, 2024
MemberAuthor
I will do a manual backport in a moment. |
GH-126802 is a backport of this pull request to the 3.13 branch. |
sobolevn added a commit
to sobolevn/cpython
that referenced
this pull request
Nov 13, 2024
…n.py` (pythonGH-126394) (cherry picked from commit 12ca7e6) Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit
that referenced
this pull request
Nov 14, 2024
picnixz pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
ebonnal pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also enabled
returnerror code and fix two problems with it.I decided to split
strict_optionalPRs based on modules for easier reviews :)