Uh oh!
There was an error while loading. Please reload this page.
gh-115999: Add free-threaded specialization for COMPARE_OP - #126410
Conversation
mpage
left a comment
There was a problem hiding this comment.
LGTM! Please add a short explanation of why the specialized instructions are thread-safe to either the pull request or the commit (when it's merged).
markshannon
left a comment
There was a problem hiding this comment.
The approach looks sound, but the test will need moving and should not rely on specific sequences of instructions.
Uh oh!
There was an error while loading. Please reload this page.
When you're done making the requested changes, leave the comment: |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…E_OP specialization in general.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Yhg1s
commented
Dec 11, 2024
Sorry, that's Google for: I have made the requested changes; please review again. |
Thanks for making the requested changes! @markshannon, @mpage: please review the changes made to this pull request. |
mpage
left a comment
There was a problem hiding this comment.
LGTM. I queued benchmark runs for both the free-threaded and default builds for this PR. Let's wait until we have the results before merging this.
mpage
commented
Dec 12, 2024
Performance doesn't look like a blocker:
|
Yhg1s
commented
Dec 17, 2024
@markshannon All your concerns should have been addressed, do you want to take another look? |
corona10
commented
Dec 19, 2024
Yhg1s
commented
Dec 20, 2024
…hon#126410) Add free-threaded specialization for COMPARE_OP, and tests for COMPARE_OP specialization in general. Co-authored-by: Donghee Na <donghee.na92@gmail.com>

Add free-threaded specialization for COMPARE_OP, and tests for COMPARE_OP specialization in general. This relies on thread-local bytecode and atomic operations to update the counters and bytecode, which are single operations.
--disable-gilbuilds #115999