Skip to content

Postpone module.__loader__ deprecation to Python 3.16 - #126482

Merged
hauntsaninja merged 1 commit into
python:mainfrom
hugovk:docs-postpone-module-loader-deprecation
Nov 10, 2024
Merged

Postpone module.__loader__ deprecation to Python 3.16#126482
hauntsaninja merged 1 commit into
python:mainfrom
hugovk:docs-postpone-module-loader-deprecation

Conversation

@hugovk

@hugovkhugovk commented Nov 6, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Related to #122255:

There was a flaw in implementation of the warnings so we should first fix the warnings in 3.14 and prolong the deprecation period until 3.16.

See also #123011.

📚 Documentation preview 📚: https://cpython-previews--126482.org.readthedocs.build/

@hugovkhugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 6, 2024
@hugovk
hugovk requested a review from willingc as a code ownerNovember 6, 2024 10:26
@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news awaiting core review labels Nov 6, 2024
rpshbhandari
rpshbhandari reviewed Nov 8, 2024
View reviewed changes

@rpshbhandarirpshbhandari left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on catching this one.

@hauntsaninja
hauntsaninja merged commit 450db61 into python:mainNov 10, 2024
@miss-islington-app

miss-islington-appBot commented Nov 10, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 10, 2024

Copy link
Copy Markdown

Sorry, @hugovk and @hauntsaninja, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 450db61a78989c5a1f1106be01e071798c783cf9 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2024
@hugovk@miss-islington
Postponemodule.__loader__deprecation to Python 3.16 (pythonGH-126482
2d9e9ae
)
(cherry picked from commit 450db61)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Nov 10, 2024

Copy link
Copy Markdown

GH-126637 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Nov 10, 2024
hauntsaninja pushed a commit to hauntsaninja/cpython that referenced this pull request Nov 10, 2024
@hugovk@hauntsaninja
Postponemodule.__loader__deprecation to Python 3.16 (python#126482)
ed74ca5
(cherry picked from commit 450db61)
@bedevere-app

bedevere-appBot commented Nov 10, 2024

Copy link
Copy Markdown

GH-126638 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Nov 10, 2024
@bedevere-app

bedevere-appBot commented Nov 10, 2024

Copy link
Copy Markdown

GH-126638 is a backport of this pull request to the 3.13 branch.

hauntsaninja pushed a commit that referenced this pull request Nov 10, 2024
@miss-islington@hugovk
[3.12] Postponemodule.__loader__deprecation to Python 3.16 (GH-12…
61e6f09
…6482) (#126637)
Postpone `module.__loader__` deprecation to Python 3.16 (GH-126482)
(cherry picked from commit 450db61)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hauntsaninja added a commit that referenced this pull request Nov 10, 2024
@hauntsaninja@hugovk
[3.13] Postponemodule.__loader__deprecation to Python 3.16 (GH-12…
fa3ee75
…6482) (#126638)
Postpone `module.__loader__` deprecation to Python 3.16 (#126482)
(cherry picked from commit 450db61)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk
hugovk deleted the docs-postpone-module-loader-deprecation branch November 10, 2024 09:44
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@hugovk@picnixz
Postponemodule.__loader__deprecation to Python 3.16 (python#126482)
1fc5262
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@hugovk@ebonnal
Postponemodule.__loader__deprecation to Python 3.16 (python#126482)
f8852a9
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja approved these changes
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner
+1 more reviewer
@rpshbhandarirpshbhandarirpshbhandari left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@hauntsaninjahauntsaninja

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@hauntsaninja@rpshbhandari