Skip to content

gh-119786: add code object doc, inline locations.md into it - #126832

Merged
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:code_object_doc
Nov 22, 2024
Merged

gh-119786: add code object doc, inline locations.md into it#126832
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:code_object_doc

Conversation

@iritkatriel

@iritkatrieliritkatriel commented Nov 14, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Nov 14, 2024
Closed
@AlexWaygood

AlexWaygood commented Nov 14, 2024

Copy link
Copy Markdown
Member

I'm super busy at work right now -- happy to take a look, but probably won't have a chance to until at least the weekend

Eclips4
Eclips4 reviewed Nov 14, 2024
View reviewed changes
Comment threadObjects/lnotab_notes.txt Outdated
iritkatriel
iritkatriel commented Nov 14, 2024
View reviewed changes
Comment threadObjects/lnotab_notes.txt Outdated
AlexWaygood
AlexWaygood approved these changes Nov 19, 2024
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment threadInternalDocs/code_objects.md Outdated
Comment threadInternalDocs/code_objects.md Outdated
Comment threadInternalDocs/code_objects.md Outdated
Comment threadInternalDocs/code_objects.md Outdated
Comment threadInternalDocs/code_objects.md Outdated
Comment threadInternalDocs/code_objects.md Outdated
@iritkatriel@AlexWaygood
Apply suggestions from code review
93cc192
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
markshannon
markshannon requested changes Nov 22, 2024
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, otherwise LGTM.

Comment threadInternalDocs/code_objects.md Outdated
Comment threadInternalDocs/code_objects.md Outdated
Comment threadInternalDocs/code_objects.md Outdated

> [!NOTE]
> `co_linetable` is not to be confused with `co_lnotab`.
> For backwards compatibility, `co_lnotab` stores the format

@markshannonmarkshannonNov 22, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that co_lnotab is lazily created from co_linetable when requested

@bedevere-app

bedevere-appBot commented Nov 22, 2024

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@iritkatriel

iritkatriel commented Nov 22, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks. I have made the requested changes; please review again.

@bedevere-app

bedevere-appBot commented Nov 22, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon, @AlexWaygood: please review the changes made to this pull request.

@iritkatriel
iritkatriel merged commit 4b12a6f into python:mainNov 22, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@iritkatriel@ebonnal
pythongh-119786: add code object doc, inline locations.md into it (py…
4ff09eb
…thon#126832)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4Eclips4Eclips4 left review comments
@markshannonmarkshannonmarkshannon approved these changes
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel@AlexWaygood@markshannon@Eclips4