Uh oh!
There was an error while loading. Please reload this page.
gh-127041: Prevent new threads after an interpreter has started finalizing - #127044
gh-127041: Prevent new threads after an interpreter has started finalizing#127044ZeroIntensity wants to merge 6 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ZeroIntensity
commented
Nov 20, 2024
I'm not too sure how I broke the threading tests with this. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ZeroIntensity
commented
Nov 20, 2024
As it turns out, the threading aborts are a result of a separate bug, I just managed to trigger it by raising in import_interpretersinterp=_interpreters.create()
source="""import threadingdef task(): time.sleep(100)t = threading.Thread(target=task)t.start()"""_interpreters.run_string(interp, source)This causes an assertion failure on my end: I'm pretty sure that the problem is that even though the interpreter doesn't have a |
This PR is stale because it has been open for 30 days with no activity. |
cc @ericsnowcurrently
I decided to use a sentinel pointer instead of a new field like I originally did, which I think is a little better. I've left a few open issues as
XXXcomments :)_interpreters.destroy#127041