Uh oh!
There was an error while loading. Please reload this page.
Allow local use of static PyMutex in the C analyzer - #127102
Conversation
vstinner
commented
Nov 21, 2024
Can you rebase your PR on the main branch and remove: diff --git a/Tools/c-analyzer/cpython/ignored.tsv b/Tools/c-analyzer/cpython/ignored.tsv
index 4327a111eed..686f3935d91 100644
--- a/Tools/c-analyzer/cpython/ignored.tsv+++ b/Tools/c-analyzer/cpython/ignored.tsv@@ -739,7 +739,6 @@ Modules/expat/xmlrole.c - declClose -
Modules/expat/xmlrole.c - error -
## other
-Modules/grpmodule.c grp_getgrall_impl getgrall_mutex -
Modules/_io/_iomodule.c - _PyIO_Module -
Modules/_sqlite/module.c - _sqlite3module -
Modules/clinic/md5module.c.h _md5_md5 _keywords - |
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Would you mind removing any corresponding variables from ignored.tsv (and/or globals-to-fix.tsv), like the one added in gh-127055? That would help verify that this change is working right.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
ZeroIntensity
commented
Nov 21, 2024
Ok, the ignore from Victor's PR has been removed. I'll do a more thorough audit of what needs to get un-ignored when I'm more available later today. |
ZeroIntensity
commented
Nov 21, 2024
Hmm, this seems like a bedevere bug. This should still have |
ZeroIntensity
commented
Nov 22, 2024
Did a search, and it looks like no other mutexes need to get un-ignored. We're good to merge. |
vstinner
commented
Nov 22, 2024
Merged, thanks. |
As seen with gh-127055, the C analyzer doesn't like
staticlocal variables, but it's fine to do so for aPyMutex. If we want to use a similar approach for other libc functions (as mentioned in gh-127081), it would be better to gracefully handle this instead of adding toignored.tsvevery time.