gh-127146: Emscripten: Skip segfaults in test suite by hoodmane · Pull Request #127151 · python/cpython

hoodmane · 2024-11-22T14:35:03Z

After this, Emscripten makes it all the way through the test suite when I run it locally.

Issue: Emscripten: Get test suite passing #127146

mdboom

Sorry if this sounds overly pedantic, but isn't this "skipping tests that segfault" rather than "fixing tests that segfault"? It's a completely reasonably path to skip these tests and then come back later to fix them (if they matter), but I would suggest changing the PR title / commit message.

bedevere-app · 2024-11-23T01:44:48Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

hoodmane · 2024-11-23T11:42:12Z

As a mathematician I have no right to call anyone pedantic under practically any circumstances.

After this, Emscripten makes it all the way through the test suite when I run it locally.

hoodmane · 2024-11-23T18:05:14Z

Seems like I can remove a lot of these xfails if I set -sSTACK_SIZE=10mb instead of 5mb.

hoodmane · 2024-11-23T18:07:01Z

Nevermind that is not true.

freakboy3742

The set of changes all looks fine to me.

However, if this is going to be a common mode of failure for tests (which this PR seems to indicate it will be), I'd rather see it pulled into a utility decorator, analogous to requires_subprocess (e.g., requires_full_stack?) so that the skip message is consistent.

hoodmane · 2024-11-30T15:03:04Z

Okay @freakboy3742 I made a common method for the stack-overflow skips. I also updated the description according to @mdboom's complaint.

I have made the requested changes; please review again

bedevere-app · 2024-11-30T15:03:08Z

Thanks for making the requested changes!

@freakboy3742, @mdboom: please review the changes made to this pull request.

freakboy3742

One possible cleanup that I should have found on my first pass. There's also a bunch of CI failures that I'm fairly sure are due to one misapplied test decorator.

bedevere-app · 2024-12-02T02:04:24Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

hoodmane · 2024-12-02T12:04:05Z

Okay, I have made the requested changes; please review again

bedevere-app · 2024-12-02T12:04:10Z

Thanks for making the requested changes!

@mdboom, @freakboy3742: please review the changes made to this pull request.

freakboy3742

LGTM - thanks for those fixes!

freakboy3742 · 2024-12-02T22:45:09Z

@mdboom Do the changes @hoodmane has made address your concerns? I'm happy to merge in the current state.

Eclips4

test_ast changes looks good to me.

hoodmane · 2024-12-04T10:03:53Z

If @mdboom doesn't come back to approve this, maybe you can merge it @freakboy3742? I think I addressed his comment...

) Added skips for tests known to cause problems when running on Emscripten. These mostly relate to the limited stack depth on Emscripten.

hoodmane requested review from Eclips4, barneygale, corona10, erlend-aasland, iritkatriel, markshannon and rhettinger as code owners November 22, 2024 14:35

bedevere-appBot added the awaiting review label Nov 22, 2024

bedevere-appBot mentioned this pull request Nov 22, 2024
Emscripten: Get test suite passing #127146
Closed

hoodmane force-pushed the fix-emscripten-test-segfaults branch 2 times, most recently from a281d38 to c11b73bCompare November 22, 2024 14:37

hoodmane requested a review from freakboy3742 November 22, 2024 14:37

Eclips4 added the skip news label Nov 22, 2024

rhettinger removed their request for review November 22, 2024 20:16

mdboom requested changes Nov 23, 2024
View reviewed changes

bedevere-appBot removed the awaiting review label Nov 23, 2024

bedevere-appBot added the awaiting changes label Nov 23, 2024

hoodmane changed the title ~~gh-127146 Emscripten: Fix segfaults in test suite~~gh-127146 Emscripten: Skip segfaults in test suiteNov 23, 2024

pythongh-127146Emscripten: Skip segfaults in test suite
c6425ea
After this, Emscripten makes it all the way through the test suite when I run it locally.

hoodmane force-pushed the fix-emscripten-test-segfaults branch from c11b73b to c6425eaCompare November 23, 2024 17:43

hoodmane added awaiting review and removed awaiting changes labels Nov 25, 2024

erlend-aasland changed the title ~~gh-127146 Emscripten: Skip segfaults in test suite~~gh-127146: Emscripten: Skip segfaults in test suiteNov 26, 2024

freakboy3742 requested changes Nov 29, 2024
View reviewed changes

bedevere-appBot added awaiting changes and removed awaiting review labels Nov 29, 2024

Cleanup
16ca044

bedevere-appBot added awaiting change review and removed awaiting changes labels Nov 30, 2024

bedevere-appBot requested review from freakboy3742 and mdboom November 30, 2024 15:03

freakboy3742 requested changes Dec 2, 2024
View reviewed changes

Comment threadLib/test/test_capi/test_misc.py Outdated
Comment threadLib/test/mapping_tests.py Outdated

bedevere-appBot removed the awaiting change review label Dec 2, 2024

bedevere-appBot added the awaiting changes label Dec 2, 2024

hoodmane added 2 commits December 2, 2024 12:02

Add requires_subinterpreters decorator
ce736ec

Typo fix
ea21724

bedevere-appBot added awaiting change review and removed awaiting changes labels Dec 2, 2024

bedevere-appBot requested a review from freakboy3742 December 2, 2024 12:04

erlend-aasland removed their request for review December 2, 2024 21:43

freakboy3742 approved these changes Dec 2, 2024
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting change review labels Dec 2, 2024

Merge branch 'main' into fix-emscripten-test-segfaults
75115e2

Eclips4 approved these changes Dec 3, 2024
View reviewed changes

mdboom approved these changes Dec 4, 2024
View reviewed changes

freakboy3742 merged commit 43634fc into python:mainDec 5, 2024

bedevere-appBot removed the awaiting merge label Dec 5, 2024

Uh oh!

Uh oh!

Conversation

hoodmane commented Nov 22, 2024• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdboom left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-appBot commented Nov 23, 2024

Uh oh!

hoodmane commented Nov 23, 2024

Uh oh!

hoodmane commented Nov 23, 2024

Uh oh!

hoodmane commented Nov 23, 2024

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

hoodmane commented Nov 30, 2024

Uh oh!

bedevere-appBot commented Nov 30, 2024

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-appBot commented Dec 2, 2024

Uh oh!

hoodmane commented Dec 2, 2024

Uh oh!

bedevere-appBot commented Dec 2, 2024

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

freakboy3742 commented Dec 2, 2024

Uh oh!

Eclips4 left a comment

Choose a reason for hiding this comment

Uh oh!

hoodmane commented Dec 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hoodmane commented Nov 22, 2024•
edited by bedevere-app Bot
Loading