Skip to content

gh-127335: Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios - #127336

Open
rruuaanng wants to merge 3 commits into
python:mainfrom
rruuaanng:add-term-const
Open

gh-127335: Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios#127336
rruuaanng wants to merge 3 commits into
python:mainfrom
rruuaanng:add-term-const

Conversation

@rruuaanng

@rruuaanngrruuaanng commented Nov 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Mainly synchronize the latest modem lines constants to the termios module.

@bedevere-appbedevere-appBot mentioned this pull request Nov 27, 2024
Open
@rruuaanngrruuaanng changed the title gh-127335: Add the latest termios macro constantsgh-127335: Add latest modem lines constants to termios moduleNov 27, 2024
ZeroIntensity
ZeroIntensity approved these changes Nov 28, 2024
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

As far as I can tell, we don't have explicit tests or documentation for any of the other macros, so I think we're good.

erlend-aasland
erlend-aasland reviewed Nov 29, 2024
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2024-11-27-23-13-21.gh-issue-127335.IiqYeX.rst Outdated
erlend-aasland
erlend-aasland reviewed Nov 29, 2024
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2024-11-27-23-13-21.gh-issue-127335.IiqYeX.rst Outdated
@erlend-aaslanderlend-aasland changed the title gh-127335: Add latest modem lines constants to termios modulegh-127335: Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termiosNov 29, 2024
@erlend-aaslanderlend-aasland self-assigned this Nov 29, 2024
@erlend-aaslanderlend-aasland linked an issue Nov 29, 2024 that may be closed by this pull request
Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP constants to termios#127335
Open
@erlend-aasland

erlend-aasland commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

As you've been told previously, please spell out the actual change in the PR title.

LocoabordoR8

This comment was marked as spam.

Sign in to view

@LocoabordoR8

This comment was marked as spam.

Sign in to view
@erlend-aaslanderlend-aasland removed their assignment May 11, 2025
@github-actions

github-actionsBot commented Apr 20, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@ZeroIntensityZeroIntensityZeroIntensity approved these changes
+1 more reviewer
@LocoabordoR8LocoabordoR8LocoabordoR8 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting mergestaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP constants to termios

4 participants

@rruuaanng@erlend-aasland@LocoabordoR8@ZeroIntensity