Skip to content

gh-127503: Emscripten make Python.sh function as proper Python CLI - #127506

Merged
freakboy3742 merged 15 commits into
python:mainfrom
hoodmane:emscripten-cli-fixes
Dec 5, 2024
Merged

gh-127503: Emscripten make Python.sh function as proper Python CLI#127506
freakboy3742 merged 15 commits into
python:mainfrom
hoodmane:emscripten-cli-fixes

Conversation

@hoodmane

@hoodmanehoodmane commented Dec 2, 2024•
edited by freakboy3742
Loading

Copy link
Copy Markdown
Contributor
  • The first commit fixes (I hope) the problems with bsd realpath.
  • The second commit adjusts python.sh to mount all directories from the native file system except /dev, /lib and /proc.
  • The third commit makes native environment variables visible in Emscripten.
  • The fourth commit changes the make target to all so that we can run tests in-tree. Now that Python can see pybuilddir.txt all of the paths work correctly running in-tree.
  • The fifth commit adds a NODEFLAGS environment variable that allows us to change the way we invoke node (for example to enable experimental features or debugging)

Fixes#127503
Fixes#127111

@bedevere-appbedevere-appBot mentioned this pull request Dec 2, 2024
Closed
@hoodmane
Pass flags in NODEFLAGS environment variable to node
af99603
Useful for: --experimental flags, --inspect flags, etc.
@hoodmane
hoodmane removed the request for review from brettcannonDecember 2, 2024 13:28
@hoodmanehoodmane mentioned this pull request Dec 2, 2024
Merged
hoodmane
hoodmane commented Dec 2, 2024
View reviewed changes
Comment threadTools/wasm/emscripten/__main__.py Outdated
mdboom
mdboom approved these changes Dec 2, 2024
View reviewed changes
Comment threadTools/wasm/emscripten/__main__.py Outdated
Comment threadTools/wasm/emscripten/__main__.py Outdated
@hoodmane

hoodmane commented Dec 2, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review @mdboom!

@erlend-aasland
erlend-aasland removed their request for review December 2, 2024 21:42
freakboy3742
freakboy3742 requested changes Dec 2, 2024
View reviewed changes

@freakboy3742freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me once I've made the couple of tweaks suggested inline; plus one question for my own edification.

Comment threadTools/wasm/emscripten/__main__.py Outdated
Comment threadTools/wasm/emscripten/__main__.py Outdated
Comment threadTools/wasm/emscripten/node_entry.mjs
@bedevere-app

bedevere-appBot commented Dec 2, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@freakboy3742freakboy3742 mentioned this pull request Dec 2, 2024
Closed
@hoodmane
Fix python.sh template
af17844
@hoodmane
Be more careful with handling of the program name
ca741bc
Previous version only worked if the name was python.sh. If we symlink something
else to it (say `python`) it would fail. This update makes it not depend on the
name of the link.
freakboy3742
freakboy3742 reviewed Dec 4, 2024
View reviewed changes
Comment threadTools/wasm/emscripten/__main__.py Outdated
freakboy3742
freakboy3742 approved these changes Dec 5, 2024
View reviewed changes

@freakboy3742freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742
freakboy3742 merged commit 87faf0a into python:mainDec 5, 2024
@hoodmanehoodmane mentioned this pull request Dec 5, 2024
Merged
@hoodmane
hoodmane deleted the emscripten-cli-fixes branch December 9, 2024 15:26
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane@srinivasreddy
pythongh-127503: Emscripten make Python.sh function as proper Python …
6c4b1ca
…CLI (python#127506)
Modifies the python.sh script to work on macOS, and adapt to recent emscripten changes.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742freakboy3742freakboy3742 approved these changes
@mdboommdboommdboom approved these changes
@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Emscripten: Make python.sh function as proper Python CLI Emscripten: Make the web example work again

3 participants

@hoodmane@freakboy3742@mdboom