Skip to content

gh-127146: Resolve some minor problems in Emscripten tests - #127565

Merged
freakboy3742 merged 1 commit into
python:mainfrom
hoodmane:fix-minor-emscripten-tests
Dec 4, 2024
Merged

gh-127146: Resolve some minor problems in Emscripten tests#127565
freakboy3742 merged 1 commit into
python:mainfrom
hoodmane:fix-minor-emscripten-tests

Conversation

@hoodmane

@hoodmanehoodmane commented Dec 3, 2024

Copy link
Copy Markdown
Contributor
  • Emscripten has_strftime_extensions
  • fma doesn't handle negative zero correctly in Emscripten
  • Emscripten has similar limited stack depth to wasi and apple in test_marshall

* Emscripten has_strftime_extensions
* fma doesn't handle negative zero correctly in Emscripten
* Emscripten has similar limited stack depth to wasi and apple in test_marshall
@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Dec 3, 2024
@hoodmanehoodmane changed the title gh-127146: Skip some minor problems in Emscripten testsgh-127146: Resolve some minor problems in Emscripten testsDec 3, 2024

@freakboy3742freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 These all make sense; thanks for the PR.

@freakboy3742
freakboy3742 merged commit 0f91078 into python:mainDec 4, 2024
@hoodmane
hoodmane deleted the fix-minor-emscripten-tests branch December 4, 2024 10:16
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
…hon#127565)
Adjusts some Emscripten test exclusions regarding strftime, fma, and stack depth.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS-emscriptenskip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hoodmane@freakboy3742