Uh oh!
There was an error while loading. Please reload this page.
gh-127572: Fix test_structmembers initialization - #127577
Merged
Merged
Conversation
The 'C' format code expects an `int` as a destination (not a `char`). This led to test failures on big-endian platforms like s390x. Use the 'c' format code, which expects a `char` as the destination (but requires a Python byte objects instead of a str).
colesbury
commented
Dec 3, 2024
ContributorAuthor
!buildbot s390x |
bedevere-bot
commented
Dec 3, 2024
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 0a547aa 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
encukou
approved these changes
Dec 4, 2024
encukou
commented
Dec 4, 2024
Member
Thank you! |
dpdani
commented
Dec 4, 2024
Contributor
thanks! |
srinivasreddy pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…7577) pythongh-127572: Fix `test_structmembers` initialization. The 'C' format code expects an `int` as a destination (not a `char`). This led to test failures on big-endian platforms like s390x. Use the 'c' format code, which expects a `char` as the destination (but requires a Python byte objects instead of a str).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'C' format code expects an
intas a destination (not achar). This led to test failures on big-endian platforms like s390x. Use the 'c' format code, which expects acharas the destination (but requires a Python byte objects instead of a str).test_charintest_structmembersfails on s390x #127572