gh-127691: add type checks when using `PyUnicodeError` objects - #127694

Merged

encukou merged 13 commits into

python:mainfrom

picnixz:feat/codecs/check-types-127691

Dec 13, 2024

picnixz commented Dec 6, 2024•
edited by bedevere-app Bot
Loading

Member

I think there will be CI failures so I'll fix them when the CI completes.

Issue: Check for type consistency for PyUnicodeError API #127691

picnixz added 2 commits

December 6, 2024 15:49

add type checks when using PyUnicodeError objects

bd07ea4

reduce un-necessary casts

21bcef2

bedevere-appBot mentioned this pull request

Check for type consistency for PyUnicodeError API #127691

Closed

picnixz added 5 commits

December 6, 2024 16:42

fix check

17d2665

fix tests

bac5031

blurb

37655a2

fix typo

af7e7bb

fix refs

a8bfd70

picnixz marked this pull request as ready for review

December 6, 2024 16:07

picnixz requested a review from iritkatriel as a code owner

December 6, 2024 16:07

bedevere-appBot added the awaiting review label

picnixz requested a review from encukou

December 6, 2024 16:22

ZeroIntensity reviewed

View reviewed changes

Objects/exceptions.c

ZeroIntensity commented Dec 7, 2024

Member

Will do a thorough review after I finish reviewing a few other things :)

ZeroIntensity reviewed

View reviewed changes

Doc/whatsnew/3.14.rst Outdated

Objects/exceptions.c Outdated

Objects/exceptions.c Outdated

Objects/exceptions.c

Objects/exceptions.c

Objects/exceptions.c Outdated

Update CHANGELOG

0ec814e

picnixz commented

View reviewed changes

Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Outdated

Objects/exceptions.c Outdated

Objects/exceptions.c Outdated

Objects/exceptions.c

Objects/exceptions.c Outdated

Apply suggestions from code review

7c7d20c

picnixz commented

View reviewed changes

Objects/exceptions.c Outdated

Update Objects/exceptions.c

49a32cf

picnixz commented

View reviewed changes

Objects/exceptions.c Outdated

Update Objects/exceptions.c

a5ee3d0

picnixz commented

View reviewed changes

Doc/whatsnew/3.14.rst Outdated

Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Outdated

Fix English

7fe6e67

picnixz commented

View reviewed changes

Doc/whatsnew/3.14.rst Outdated

Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Outdated

Improve wording

970720a

This was referenced Dec 10, 2024

Refactor PyUnicodeError internal C helpers #127787

Closed

gh-127787: refactor helpers for PyUnicodeErrorObject internal interface #127789

Merged

encukou merged commit 8bc1818 into python:main

bedevere-appBot removed the awaiting review label

encukou commented Dec 13, 2024

Member

Thank you!

picnixz deleted the feat/codecs/check-types-127691 branch

December 13, 2024 16:21

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request

pythongh-127691: add type checks when usingPyUnicodeErrorobjects (p…

a7aa09b

…ythonGH-127694)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment