Skip to content

gh-127740: Add some more tests for earlier PR #127756 - #127818

Merged
hauntsaninja merged 3 commits into
python:mainfrom
srinivasreddy:gh-127740
Dec 12, 2024
Merged

gh-127740: Add some more tests for earlier PR #127756#127818
hauntsaninja merged 3 commits into
python:mainfrom
srinivasreddy:gh-127740

Conversation

@srinivasreddy

@srinivasreddysrinivasreddy commented Dec 11, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

gh-127740: Add some more tests for earlier PR #127756

via - #127756 (comment)

@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Dec 11, 2024
@bedevere-appbedevere-appBot mentioned this pull request Dec 11, 2024
Closed
@srinivasreddy
srinivasreddy marked this pull request as ready for review December 11, 2024 11:16
@srinivasreddy

srinivasreddy commented Dec 11, 2024

Copy link
Copy Markdown
ContributorAuthor

cc @hauntsaninja@cfbolz

@srinivasreddysrinivasreddy mentioned this pull request Dec 11, 2024
Merged
ZeroIntensity
ZeroIntensity reviewed Dec 11, 2024
View reviewed changes
Comment threadLib/test/test_bytes.py Outdated
@srinivasreddy@ZeroIntensity
Update Lib/test/test_bytes.py
0655690
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
hauntsaninja
hauntsaninja approved these changes Dec 12, 2024
View reviewed changes

@hauntsaninjahauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

hauntsaninja
hauntsaninja approved these changes Dec 12, 2024
View reviewed changes

@hauntsaninjahauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja
hauntsaninja enabled auto-merge (squash) December 12, 2024 02:18
@hauntsaninja
hauntsaninja merged commit c33b6fb into python:mainDec 12, 2024
srinivasreddy added a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@srinivasreddy
pythongh-127740: Add some more tests for earlier PRpython#127756(py…
ad2e37c
…thon#127818)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments
@hauntsaninjahauntsaninjahauntsaninja approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srinivasreddy@hauntsaninja@ZeroIntensity@skirpichev