Uh oh!
There was an error while loading. Please reload this page.
gh-127146: Some expected failures in Emscripten time tests - #127843
Merged
Conversation
This xfails two tests in the test_time suite. It also adjusts test_os to reflect the fact that in Emscripten file modification times in nanoseconds since the linux epoch get round tripped through a 53 bit integer so we only get 5 subsecond digits of precision.
freakboy3742
approved these changes
Dec 12, 2024
freakboy3742
left a comment
Contributor
There was a problem hiding this comment.
👍 An annoying discrepancy on subsection accuracy, but this is a pragmatic workaround until such time as this can be fixed upstream.
srinivasreddy pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…hon#127843) Disables two tests in the test_time suite, and adjusts test_os to reflect precision limits in Emscripten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This xfails two tests in the test_time suite. It also adjusts test_os to reflect the fact that in Emscripten file modification times in nanoseconds since the linux epoch get round tripped through a 53 bit integer so we only get 5 subsecond digits of precision.