Skip to content

gh-127865: build failure fix for systems without thread-locals support - #127866

Merged
colesbury merged 2 commits into
python:mainfrom
velemas:bugfix_127865
Dec 12, 2024
Merged

gh-127865: build failure fix for systems without thread-locals support#127866
colesbury merged 2 commits into
python:mainfrom
velemas:bugfix_127865

Conversation

@velemas

@velemasvelemas commented Dec 12, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This PR fixes the build issue introduced by the commit 628f6eb from the PR #112207 on systems without thread-locals support.

@ghost

ghost commented Dec 12, 2024•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-appbedevere-appBot mentioned this pull request Dec 12, 2024
Closed
@bedevere-app

bedevere-appBot commented Dec 12, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ZeroIntensity

ZeroIntensity commented Dec 12, 2024

Copy link
Copy Markdown
Member

I think we do need a news entry here.

@ZeroIntensityZeroIntensity added the needs backport to 3.13 bugs and security fixes label Dec 12, 2024
ZeroIntensity
ZeroIntensity approved these changes Dec 12, 2024
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one comment about the blurb.

Comment threadMisc/NEWS.d/next/Build/2024-12-12-14-46-19.gh-issue-127865.hruu1j.rst Outdated
@bedevere-app

bedevere-appBot commented Dec 12, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@colesbury
colesbury merged commit f823910 into python:mainDec 12, 2024
@miss-islington-app

miss-islington-appBot commented Dec 12, 2024

Copy link
Copy Markdown

Thanks @velemas for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 12, 2024
@velemas@miss-islington
pythongh-127865: Fix build failure for systems without thread local s…
52a58bd
…upport (pythonGH-127866)
This PR fixes the build issue introduced by the commit 628f6eb from
pythonGH-112207 on systems without thread local support.
(cherry picked from commit f823910)
Co-authored-by: velemas <10437413+velemas@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Dec 12, 2024

Copy link
Copy Markdown

GH-127882 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Dec 12, 2024
colesbury pushed a commit that referenced this pull request Dec 12, 2024
@miss-islington@velemas
[3.13]gh-127865: Fix build failure for systems without thread local …
f21b38c
…support (GH-127866) (GH-127882)
This PR fixes the build issue introduced by the commit 628f6eb from
GH-112207 on systems without thread local support.
(cherry picked from commit f823910)
Co-authored-by: velemas <10437413+velemas@users.noreply.github.com>
@velemas
velemas deleted the bugfix_127865 branch December 12, 2024 18:44
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@velemas@srinivasreddy
pythongh-127865: Fix build failure for systems without thread local s…
8dd7f1a
…upport (pythonGH-127866)
This PR fixes the build issue introduced by the commit 628f6eb from
pythonGH-112207 on systems without thread local support.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes
@ZeroIntensityZeroIntensityZeroIntensity approved these changes
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@velemas@ZeroIntensity@colesbury