Uh oh!
There was an error while loading. Please reload this page.
GH-127970: find the runtime library when dladdr is available - #127972
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net
Signed-off-by: Filipe Laíns <lains@riseup.net
Signed-off-by: Filipe Laíns <lains@riseup.net
Signed-off-by: Filipe Laíns <lains@riseup.net
Signed-off-by: Filipe Laíns <lains@riseup.net
FFY00
commented
Dec 15, 2024
If this gets backported, GH-127974 should too, to ensure we don't end up with mismatched prefixes from different installations. |
bedevere-bot
commented
Dec 15, 2024
Signed-off-by: Filipe Laíns <lains@riseup.net
Signed-off-by: Filipe Laíns <lains@riseup.net
FFY00
commented
Dec 17, 2024
@edelsohn, @ayappanec, I was unable to find much concrete information regarding the |
ayappanec
commented
Dec 17, 2024
AIX don't have dladdr. The IBM documentation is about z/TPF operating system ( and not AIX). |
FFY00
commented
Dec 17, 2024
Ah, gotcha! Thanks! |
Signed-off-by: Filipe Laíns <lains@riseup.net
Signed-off-by: Filipe Laíns <lains@riseup.net
FFY00
commented
Dec 17, 2024
I tested this on macOS in framework and non-framework builds, and seems to work fine. I'll give it a couple more days for other to have time to review. |
ned-deily
commented
Jan 7, 2025
My apologies for the delay in testing. The PR as it stands appears to break installed macOS frameworks builds, the standard configuration used by many downstream distributors including python.org installers. To reproduce without doing a system-wide install: Resulting in: |
FFY00
commented
Jan 7, 2025
Thank you for the feedback, I'll have a look! |
Signed-off-by: Filipe Laíns <lains@riseup.net
FFY00
commented
Jan 7, 2025
Okay, this was a bit tricky to debug, but it seems like the Could you confirm that it fixes the issue on your side? |
ned-deily
commented
Jan 8, 2025
Yes, thanks, that does solve the build problem. |
ned-deily
left a comment
There was a problem hiding this comment.
With the build fix, I did builds and tests on current macOS versions of all three install variants - default (non-shared), shared, and framework - and noted no regressions. I also did a framework build and test on an older (macos 10.11) system with no apparent regression. Unfortunately, I didn't have available an applicable test of embedding Python on macOS. And I did not do any testing on other (non-macOS) platforms including iOS nor did I do any additional testing of venv's outside of the standard test suite. I didn't note any obvious red flags in the getpath.c changes but I'm not an expert in the details of interpreter startup across the various platforms. As such, I'm +0 on making this change; if we want to do it, we should do it soon, that is, early in the release cycle to get exposure.
Thanks for the feedback, I am gonna go ahead and sync the branch with |
Signed-off-by: Filipe Laíns <lains@riseup.net
libpythonpath into account ingetpath#127970