Skip to content

[3.12] gh-127906: Skip limited C API test_cext tests if Py_TRACE_REFS#127993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Dec 16, 2024
Merged

[3.12] gh-127906: Skip limited C API test_cext tests if Py_TRACE_REFS #127993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/test/test_cext/__init__.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,12 +8,14 @@
import shlex
import shutil
import subprocess
import sys
import unittest
from test import support


SOURCE = os.path.join(os.path.dirname(__file__), 'extension.c')
SETUP = os.path.join(os.path.dirname(__file__), 'setup.py')
Py_TRACE_REFS = hasattr(sys, 'getobjects')


# With MSVC on a debug build, the linker fails with: cannot open file
Expand DownExpand Up@@ -47,6 +49,9 @@ def test_build_limited_c11(self):
self.check_build('_test_limited_c11_cext', limited=True, std='c11')

def check_build(self, extension_name, std=None, limited=False):
if limited and Py_TRACE_REFS:
self.skipTest('Py_LIMITED_API is incompatible with Py_TRACE_REFS')

venv_dir = 'env'
with support.setup_venv_with_pip_setuptools_wheel(venv_dir) as python_exe:
self._check_build(extension_name, python_exe,
Expand Down
5 changes: 5 additions & 0 deletions Lib/test/test_cppext/__init__.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,12 +4,14 @@
import shlex
import shutil
import subprocess
import sys
import unittest
from test import support


SOURCE = os.path.join(os.path.dirname(__file__), 'extension.cpp')
SETUP = os.path.join(os.path.dirname(__file__), 'setup.py')
Py_TRACE_REFS = hasattr(sys, 'getobjects')


# With MSVC on a debug build, the linker fails with: cannot open file
Expand DownExpand Up@@ -45,6 +47,9 @@ def test_build_limited(self):
self.check_build('_testcppext_limited', limited=True)

def check_build(self, extension_name, std=None, limited=False):
if limited and Py_TRACE_REFS:
self.skipTest('Py_LIMITED_API is incompatible with Py_TRACE_REFS')

venv_dir = 'env'
with support.setup_venv_with_pip_setuptools_wheel(venv_dir) as python_exe:
self._check_build(extension_name, python_exe,
Expand Down