Skip to content

[3.13] gh-127906: Fix Py_BUILD_ASSERT_EXPR() on Windows - #127994

Merged
vstinner merged 1 commit into
python:3.13from
vstinner:build_assert_expr13
Dec 16, 2024
Merged

[3.13] gh-127906: Fix Py_BUILD_ASSERT_EXPR() on Windows#127994
vstinner merged 1 commit into
python:3.13from
vstinner:build_assert_expr13

Conversation

@vstinner

@vstinnervstinner commented Dec 16, 2024

Copy link
Copy Markdown
Member

Change Py_BUILD_ASSERT_EXPR implementation on Windows to avoid a compiler warning about an unnamed structure.

Change Py_BUILD_ASSERT_EXPR implementation on Windows to avoid a
compiler warning about an unnamed structure.
@vstinner

vstinner commented Dec 16, 2024

Copy link
Copy Markdown
MemberAuthor

Fix the following test_cext warning treated as an error:

 extension.c(56): error C2220: the following warning is treated as an error
extension.c(56): warning C4116: unnamed type definition in parentheses

@vstinner

Copy link
Copy Markdown
MemberAuthor

I tested locally that this change fix python -m test test_cext -m test_build -v -u all -m test_build_c11.

@vstinner
vstinner enabled auto-merge (squash) December 16, 2024 17:15
@vstinner

Copy link
Copy Markdown
MemberAuthor

Python 3.12 is not impacted. The main branch already contains the fix.

@vstinner
vstinner merged commit 8e143b2 into python:3.13Dec 16, 2024
@vstinner
vstinner deleted the build_assert_expr13 branch December 16, 2024 17:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner