Skip to content

gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning - #128007

Merged
brettcannon merged 15 commits into
python:mainfrom
tomasr8:importlib-deprecations
Jan 15, 2025
Merged

gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning#128007
brettcannon merged 15 commits into
python:mainfrom
tomasr8:importlib-deprecations

Conversation

@tomasr8

@tomasr8tomasr8 commented Dec 16, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Largely based on work done by @rashansmith, this adds deprecation warnings for the following importlib classes, methods and attributes (using the docs as the source of truth):

The deprecation messages are based on the docs. Warnings for DEBUG_BYTECODE_SUFFIXES and OPTIMIZED_BYTECODE_SUFFIXES are implemented using a module __getattr__.

Feedback welcome!

tomasr8and others added 7 commits December 16, 2024 21:40
@tomasr8@rashansmith
Add DeprecationWarning for path_mtime
d4844c5
Co-authored-by: rashansmith <smith.rashan@gmail.com>
@tomasr8@rashansmith
Add DeprecationWarning for ResourceLoader
cbe54a3
Co-authored-by: rashansmith <smith.rashan@gmail.com>
@tomasr8@rashansmith
Add DeprecationWarning for DEBUG_BYTECODE_SUFFIXES and OPTIMIZED_BYTE…
b73ad85
…CODE_SUFFIXES.
Co-authored-by: rashansmith <smith.rashan@gmail.com>
@tomasr8@rashansmith
Add DeprecationWarning for WindowsRegistryFinder
5375cf6
Co-authored-by: rashansmith <smith.rashan@gmail.com>
@tomasr8
Update tests
3306e7e
@tomasr8
Add news entry
5c7c5e9
@tomasr8
Unify quotes
7079bdd
@bedevere-appbedevere-appBot mentioned this pull request Dec 16, 2024
Closed
11 tasks
@tomasr8

tomasr8 commented Dec 16, 2024

Copy link
Copy Markdown
MemberAuthor

cc @StanFromIreland

StanFromIreland
StanFromIreland reviewed Dec 16, 2024
View reviewed changes

@StanFromIrelandStanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little things I noticed. I did not have time to go through the rest but it looks good in general.

Comment threadLib/importlib/_bootstrap_external.py Outdated
Comment threadLib/importlib/abc.py Outdated
tomasr8and others added 2 commits December 16, 2024 22:55
@tomasr8@StanFromIreland
Update Lib/importlib/abc.py
651e40e
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@tomasr8
Fix tests
df86fcf
This was referenced Dec 18, 2024
Closed
Open
brettcannon
brettcannon requested changes Jan 6, 2025
View reviewed changes
Comment threadLib/importlib/_bootstrap_external.py Outdated
Comment threadLib/importlib/machinery.py Outdated
Comment threadLib/importlib/machinery.py Outdated
@bedevere-app

bedevere-appBot commented Jan 6, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brettcannon

brettcannon commented Jan 6, 2025

Copy link
Copy Markdown
Member

Sorry about the review delay!

@tomasr8

tomasr8 commented Jan 7, 2025

Copy link
Copy Markdown
MemberAuthor

Sorry about the review delay!

No worries, and thanks for the review! I think I addressed your comments if you feel like having another look :)

I have made the requested changes; please review again

@bedevere-app

bedevere-appBot commented Jan 7, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

brettcannon
brettcannon reviewed Jan 14, 2025
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2024-12-16-22-20-38.gh-issue-121604.m3Xn4G.rst Outdated
@brettcannon
brettcannon merged commit bd3baa8 into python:mainJan 15, 2025
@brettcannon

brettcannon commented Jan 15, 2025

Copy link
Copy Markdown
Member

Thanks, @tomasr8 for bearing with me and my delayed reviews! 😅

@tomasr8
tomasr8 deleted the importlib-deprecations branch January 15, 2025 06:59
@tomasr8

tomasr8 commented Jan 15, 2025

Copy link
Copy Markdown
MemberAuthor

No worries :) Thanks for the review!

graingert
graingert reviewed Jan 15, 2025
View reviewed changes
Comment threadLib/importlib/abc.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon approved these changes
@graingertgraingertgraingert left review comments
@StanFromIrelandStanFromIrelandStanFromIreland left review comments
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tomasr8@brettcannon@graingert@StanFromIreland