Skip to content

gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version - #128090

Merged
vstinner merged 1 commit into
python:mainfrom
hugovk:3.14-brew-overwrite-tcl-tk
Dec 19, 2024
Merged

gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version#128090
vstinner merged 1 commit into
python:mainfrom
hugovk:3.14-brew-overwrite-tcl-tk

Conversation

@vstinner

@vstinnervstinner commented Dec 19, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Dec 19, 2024
Closed
@vstinner

vstinner commented Dec 19, 2024

Copy link
Copy Markdown
MemberAuthor

@hugovk: I took the freedom of creating a PR from your branch to check if it fix #128069.

@vstinner

vstinner commented Dec 19, 2024

Copy link
Copy Markdown
MemberAuthor

I confirm that the change fix #128069.

The macOS job was run with the macos-13 image version 20241216.479 which has the bug. The "Install Homebrew dependencies" step completed successfully.

skirpichev
skirpichev approved these changes Dec 19, 2024
View reviewed changes

@skirpichevskirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least this can be committed as a temporary fix.

@vstinner
vstinner enabled auto-merge (squash) December 19, 2024 10:18
@vstinner
vstinner merged commit 46dc1ba into python:mainDec 19, 2024
@hugovk
hugovk deleted the 3.14-brew-overwrite-tcl-tk branch December 19, 2024 12:26
@hugovkhugovk mentioned this pull request Dec 19, 2024
Closed
@vstinnervstinner added the needs backport to 3.13 bugs and security fixes label Dec 19, 2024
@miss-islington-app

miss-islington-appBot commented Dec 19, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 19, 2024
@vstinner@hugovk@miss-islington
pythongh-128069: brew link --overwrite tcl-tk@8 to prevent conflict w…
2342a48
…ith GitHub image's version (pythonGH-128090)
brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
(cherry picked from commit 46dc1ba)
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Dec 19, 2024

Copy link
Copy Markdown

GH-128096 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Dec 19, 2024
vstinner added a commit that referenced this pull request Dec 19, 2024
@miss-islington@vstinner@hugovk
[3.13]gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict …
08f9b7c
…with GitHub image's version (GH-128090) (#128096)
gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version (GH-128090)
brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
(cherry picked from commit 46dc1ba)
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@vstinnervstinner added the needs backport to 3.12 only security fixes label Dec 20, 2024
@miss-islington-app

miss-islington-appBot commented Dec 20, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2024
@vstinner@hugovk@miss-islington
pythongh-128069: brew link --overwrite tcl-tk@8 to prevent conflict w…
065753f
…ith GitHub image's version (pythonGH-128090)
brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
(cherry picked from commit 46dc1ba)
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Dec 20, 2024

Copy link
Copy Markdown

GH-128125 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Dec 20, 2024
vstinner added a commit that referenced this pull request Dec 20, 2024
@miss-islington@vstinner@hugovk
[3.12]gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict …
825b83d
…with GitHub image's version (GH-128090) (#128125)
gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version (GH-128090)
brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
(cherry picked from commit 46dc1ba)
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Dec 23, 2024
@vstinner@hugovk@srinivasreddy
pythongh-128069: brew link --overwrite tcl-tk@8 to prevent conflict w…
d0256e6
…ith GitHub image's version (python#128090)
brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@vstinner@hugovk@srinivasreddy
pythongh-128069: brew link --overwrite tcl-tk@8 to prevent conflict w…
ce1d1ee
…ith GitHub image's version (python#128090)
brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@vstinnervstinner added 3.11 only security fixes and removed 3.11 only security fixes labels Jan 22, 2025
@vstinnervstinner added the needs backport to 3.11 only security fixes label Jan 22, 2025
@miss-islington-app

miss-islington-appBot commented Jan 22, 2025

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2025
@vstinner@hugovk@miss-islington
pythongh-128069: brew link --overwrite tcl-tk@8 to prevent conflict w…
c70afc5
…ith GitHub image's version (pythonGH-128090)
brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
(cherry picked from commit 46dc1ba)
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Jan 22, 2025

Copy link
Copy Markdown

GH-129172 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Jan 22, 2025
pablogsal pushed a commit that referenced this pull request Jan 22, 2025
@miss-islington
[3.11]gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict …
49edb99
…with GitHub image's version (GH-128090) (#129172)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichevskirpichevskirpichev approved these changes
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@skirpichev@hugovk