Skip to content

gh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop() - #128172

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
graingert:fix-resource-warnings-in-test-tasks
Dec 22, 2024
Merged

gh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop()#128172
kumaraditya303 merged 1 commit into
python:mainfrom
graingert:fix-resource-warnings-in-test-tasks

Conversation

@graingert

@graingertgraingert commented Dec 22, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Dec 22, 2024
@graingertgraingert mentioned this pull request Dec 22, 2024
Closed
7 tasks
@graingertgraingert changed the title fix resource warnings in test_tasks.pygh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop()Dec 22, 2024
@graingert
graingert marked this pull request as ready for review December 22, 2024 11:05
kumaraditya303
kumaraditya303 reviewed Dec 22, 2024
View reviewed changes
Comment threadLib/test/test_asyncio/test_tasks.py
@kumaraditya303
kumaraditya303 merged commit b66a4ad into python:mainDec 22, 2024
@graingert
graingert deleted the fix-resource-warnings-in-test-tasks branch December 22, 2024 13:04
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Dec 23, 2024
@graingert@srinivasreddy
pythongh-127949: fix resource warnings intest_tasks.py(python#128172
2ad5c8f
)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@graingert@srinivasreddy
pythongh-127949: fix resource warnings intest_tasks.py(python#128172
2cebf45
)
@graingertgraingert added the needs backport to 3.13 bugs and security fixes label Mar 27, 2025
@miss-islington-app

miss-islington-appBot commented Mar 27, 2025

Copy link
Copy Markdown

Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2025
@graingert@miss-islington
pythongh-127949: fix resource warnings intest_tasks.py(pythonGH-1…
ac0688b
…28172)
(cherry picked from commit b66a4ad)
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-app

bedevere-appBot commented Mar 27, 2025

Copy link
Copy Markdown

GH-131805 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Mar 27, 2025
@graingertgraingert added the needs backport to 3.12 only security fixes label Mar 27, 2025
@miss-islington-app

miss-islington-appBot commented Mar 27, 2025

Copy link
Copy Markdown

Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2025
@graingert@miss-islington
pythongh-127949: fix resource warnings intest_tasks.py(pythonGH-1…
89abf3b
…28172)
(cherry picked from commit b66a4ad)
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-app

bedevere-appBot commented Mar 27, 2025

Copy link
Copy Markdown

GH-131806 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Mar 27, 2025
kumaraditya303 pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington@graingert
[3.13]gh-127949: fix resource warnings intest_tasks.py(GH-128172) (
924a6ce
#131805)
gh-127949: fix resource warnings in `test_tasks.py` (GH-128172)
(cherry picked from commit b66a4ad)
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
kumaraditya303 added a commit that referenced this pull request Mar 28, 2025
@miss-islington@graingert@kumaraditya303
[3.12]gh-127949: fix resource warnings intest_tasks.py(GH-128172) (
d4ddc03
#131806)
* gh-127949: fix resource warnings in `test_tasks.py` (GH-128172)
(cherry picked from commit b66a4ad)
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@graingert@kumaraditya303