Skip to content

gh-128265: support wasi/emscripten on pdb tests, by removing asyncio from pdb tests - #128264

Merged
Eclips4 merged 6 commits into
python:mainfrom
graingert:wasi-emscripten-pdb
Dec 28, 2024
Merged

gh-128265: support wasi/emscripten on pdb tests, by removing asyncio from pdb tests#128264
Eclips4 merged 6 commits into
python:mainfrom
graingert:wasi-emscripten-pdb

Conversation

@graingert

@graingertgraingert commented Dec 25, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@graingertgraingert changed the title support wasi/emscripten on pdb testssupport wasi/emscripten on pdb tests, by removing asyncio from pdb testsDec 25, 2024
@graingertgraingert changed the title support wasi/emscripten on pdb tests, by removing asyncio from pdb testsgh-128265: support wasi/emscripten on pdb tests, by removing asyncio from pdb testsDec 25, 2024
@bedevere-appbedevere-appBot mentioned this pull request Dec 25, 2024
Closed
@graingert
graingert marked this pull request as ready for review December 25, 2024 22:01
graingert
graingert commented Dec 26, 2024
View reviewed changes
Comment threadLib/test/test_pdb.py
Eclips4
Eclips4 reviewed Dec 28, 2024
View reviewed changes
Comment threadLib/test/support/__init__.py Outdated
Comment threadLib/test/test_inspect/test_inspect.py Outdated
Eclips4
Eclips4 reviewed Dec 28, 2024
View reviewed changes
Comment threadLib/test/test_pdb.py Outdated
Eclips4
Eclips4 approved these changes Dec 28, 2024
View reviewed changes

@Eclips4Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Eclips4
Eclips4 merged commit aab51c3 into python:mainDec 28, 2024
@graingert
graingert deleted the wasi-emscripten-pdb branch December 28, 2024 18:14
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@graingert@srinivasreddy
pythongh-128265: Support WASI/Emscripten on PDB tests, by removing as…
2d567cc
…yncio from pdb tests (python#128264)
A part of `Lib/test/test_pdb.py` was previously unable to run on WASI/Emscripten
platforms because it lacked support for `asyncio`.
In fact, these tests could be rewritten without the `asyncio` framework because `test_pdb` tests the behavior of coroutines, which are not part of `asyncio`.
Now reliance on the availability of `asyncio` has been removed and
part of `test_pdb` that deals with coroutines working on WASI/Emscripten platforms.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments
@Eclips4Eclips4Eclips4 approved these changes
@gaogaotiantiangaogaotiantianAwaiting requested review from gaogaotiantiangaogaotiantian is a code owner
@1st11st1Awaiting requested review from 1st1

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@graingert@sobolevn@Eclips4