Uh oh!
There was an error while loading. Please reload this page.
gh-128277: use relaxed atomics for sock_fd - #128304
Conversation
asvetlov
left a comment
There was a problem hiding this comment.
Looks good after the brief look
colesbury
commented
Dec 30, 2024
The PR is fairly straightforward, so it's fine with me if you want to merge it. I just don't think we should bother with this sort of thing in the future. |
kumaraditya303
commented
Dec 31, 2024
I see, I did this just for asyncio because tsan was complaining while running the existing test suite and this fixes all of this AFAICS. If we aren't planning to fix this maybe we should add some tsan suppressions for these for the time being? |
bedevere-bot
commented
Dec 31, 2024
|
socketmodule thread safe #128277