Uh oh!
There was an error while loading. Please reload this page.
gh-123681: Check the strftime() behavior at runtime instead of at the compile time - #128444
gh-123681: Check the strftime() behavior at runtime instead of at the compile time#128444serhiy-storchaka wants to merge 7 commits into
Conversation
…at the compile time It is needed to support cross-compiling. Remove macros Py_NORMALIZE_CENTURY and Py_STRFTIME_C99_SUPPORT.
erlend-aasland
commented
Jan 3, 2025
This PR is not needed anymore. Please see the issue history. |
serhiy-storchaka
commented
Jan 3, 2025
No, it is needed to support cross-compiling. You cannot check the runtime behavior at compile time when cross-compiling. |
erlend-aasland
commented
Jan 3, 2025
There is no need; we require C99 compliant strftime. |
serhiy-storchaka
commented
Jan 3, 2025
It is not C99 compliant (or at least not Python documentation compliant) on Linux. This is why this workaround was needed at first place. |
erlend-aasland
commented
Jan 3, 2025
If that was the case, all our Linux build bots and Linux CI would now be broken. However it is not. |
serhiy-storchaka
commented
Jan 3, 2025
I wonder why? I guess because ac_cv_normalize_century=yes if cross-compiling. |
erlend-aasland
commented
Jan 3, 2025
Because it is C99 compliant, presumably.
|
serhiy-storchaka
commented
Jan 3, 2025
erlend-aasland
commented
Jan 3, 2025
Sorry, I misread it as |
picnixz
commented
Apr 4, 2025
What's the status of this PR? |
picnixz
commented
Jun 10, 2025
@serhiy-storchaka apparently, the JIT tests for |
It is needed to support cross-compiling.
Remove macros Py_NORMALIZE_CENTURY and Py_STRFTIME_C99_SUPPORT.
test_strftime_y2kfails on embedded Linux #123681