Skip to content

gh-127146: skip Emscripten tests with pending fixes - #128549

Merged
freakboy3742 merged 5 commits into
python:mainfrom
hoodmane:emscripten-main-branch-fixed
Jan 6, 2025
Merged

gh-127146: skip Emscripten tests with pending fixes#128549
freakboy3742 merged 5 commits into
python:mainfrom
hoodmane:emscripten-main-branch-fixed

Conversation

@hoodmane

@hoodmanehoodmane commented Jan 6, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Skip some tests failures that are either fixed on the main branch of Emscripten or by an open PR.

@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Jan 6, 2025
@bedevere-appbedevere-appBot mentioned this pull request Jan 6, 2025
Closed
@hoodmanehoodmane changed the title gh-127146: skip tests that are fixed on the main branch of Emscriptengh-127146: skip Emscripten tests with pending fixesJan 6, 2025
@brettcannon
brettcannon removed their request for review January 6, 2025 17:26
freakboy3742
freakboy3742 approved these changes Jan 6, 2025
View reviewed changes

@freakboy3742freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@freakboy3742
freakboy3742 merged commit 616692d into python:mainJan 6, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane@srinivasreddy
pythongh-127146: Skip Emscripten tests with pending fixes (python#128549
9c5b386
)
Marks some additional tests as skipped on Emscripten. Many of these skips can be
reverted when the next Emscripten release is available.
@hoodmane
hoodmane deleted the emscripten-main-branch-fixed branch January 8, 2025 08:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742freakboy3742freakboy3742 approved these changes
@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoodmane@freakboy3742