Skip to content

gh-128550: TaskGroup: cancel tasks added to set after aborting - #128551

Closed
graingert wants to merge 13 commits into
python:mainfrom
graingert:fix-taskgroup-eager
Closed

gh-128550: TaskGroup: cancel tasks added to set after aborting#128551
graingert wants to merge 13 commits into
python:mainfrom
graingert:fix-taskgroup-eager

Conversation

@graingert

@graingertgraingert commented Jan 6, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Jan 6, 2025
Closed
@graingert

graingert commented Jan 6, 2025

Copy link
Copy Markdown
ContributorAuthor

I'm refactoring the tests to run the TaskGroup tests on eager and lazy tasks and have found another issue. I'm afk at the moment and will fix that one shortly too

@graingert

graingert commented Jan 6, 2025

Copy link
Copy Markdown
ContributorAuthor

Ok I have the other issue here: #128553

graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment threadLib/asyncio/taskgroups.py
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment threadLib/test/test_asyncio/test_taskgroups.py
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment threadLib/test/test_asyncio/test_taskgroups.py
@graingert
graingert marked this pull request as ready for review January 6, 2025 18:58
ZeroIntensity
ZeroIntensity reviewed Jan 6, 2025
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2025-01-06-18-58-07.gh-issue-128550.lzeWhZ.rst Outdated
Comment threadLib/test/test_asyncio/test_taskgroups.py
Comment threadLib/test/test_asyncio/test_taskgroups.py
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment threadLib/test/test_asyncio/test_taskgroups.py
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment threadLib/test/test_asyncio/test_taskgroups.py
graingert
graingert commented Jan 6, 2025
View reviewed changes
Comment threadLib/test/test_asyncio/test_taskgroups.py Outdated
@graingert
graingert deleted the fix-taskgroup-eager branch January 20, 2025 17:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner
@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

No one assigned

Labels

awaiting core reviewtopic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@graingert@ZeroIntensity@AlexWaygood