Skip to content

decimal docs: specification link and examples - #128698

Merged
hugovk merged 8 commits into
python:mainfrom
skirpichev:decimal-docs
Dec 16, 2025
Merged

decimal docs: specification link and examples#128698
hugovk merged 8 commits into
python:mainfrom
skirpichev:decimal-docs

Conversation

@skirpichev

@skirpichevskirpichev commented Jan 10, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member
  • added a direct reference to a floating-point model used
  • and few examples for formatted string output

📚 Documentation preview 📚: https://cpython-previews--128698.org.readthedocs.build/

@skirpichev
decimal docs: specification link and examples
7a335ed
* added a direct reference to a floating-point model used
* and few examples for formatted string output
@bedevere-appbedevere-appBot added docs Documentation in the Doc dir awaiting review labels Jan 10, 2025
@skirpichevskirpichev mentioned this pull request Jan 10, 2025
Closed
rruuaanng
rruuaanng reviewed Jan 10, 2025
View reviewed changes
Comment threadDoc/library/decimal.rst Outdated
skirpichevand others added 2 commits January 10, 2025 09:16
@skirpichev@rruuaanng
Update Doc/library/decimal.rst
a66b20a
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
@skirpichev
+ fix sphinx markup; sorry I was in md mode)
228091a
StanFromIreland
StanFromIreland reviewed Jan 10, 2025
View reviewed changes
Comment threadDoc/library/decimal.rst Outdated
StanFromIreland
StanFromIreland reviewed Jan 10, 2025
View reviewed changes
Comment threadDoc/library/decimal.rst Outdated
StanFromIreland
StanFromIreland reviewed Jan 10, 2025
View reviewed changes
Comment threadDoc/library/decimal.rst
@skirpichev@StanFromIreland
Update Doc/library/decimal.rst
6fb60ef
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland
StanFromIreland approved these changes Jan 11, 2025
View reviewed changes

@StanFromIrelandStanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

ericvsmith
ericvsmith reviewed Jan 23, 2025
View reviewed changes
Comment threadDoc/library/decimal.rst
@skirpichev

skirpichev commented Jan 24, 2025

Copy link
Copy Markdown
MemberAuthor

@ericvsmith, refs to format/f-strings - added.

@ericvsmith

ericvsmith commented Jan 28, 2025

Copy link
Copy Markdown
Member

@ericvsmith, refs to format/f-strings - added.

I think that's good. It doesn't mention str.format, but that's not so important any more and I hope that anyone who really cares about it knows that it's all based on __format__.

@skirpichev

skirpichev commented Jan 28, 2025

Copy link
Copy Markdown
MemberAuthor

It doesn't mention str.format, but that's not so important

I think this will be too verbose, it's already mention the format() builtin docs, which has links to __format__ and then to str.format()

@ericvsmith

ericvsmith commented Jan 29, 2025

Copy link
Copy Markdown
Member

It doesn't mention str.format, but that's not so important

I think this will be too verbose, it's already mention the format() builtin docs, which has links to __format__ and then to str.format()

Agreed.

@skirpichevskirpichev mentioned this pull request Apr 7, 2025
Merged
@skirpichevskirpichev removed the needs backport to 3.12 only security fixes label Apr 8, 2025
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@skirpichevskirpichev mentioned this pull request Jul 14, 2025
Closed
hugovk
hugovk reviewed Dec 16, 2025
View reviewed changes
Comment threadDoc/library/decimal.rst Outdated
@hugovk
hugovk enabled auto-merge (squash) December 16, 2025 11:34
@hugovk
hugovk merged commit 2450be6 into python:mainDec 16, 2025
28 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsDec 16, 2025
@miss-islington-app

miss-islington-appBot commented Dec 16, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@skirpichev@rruuaanng
@StanFromIreland@hugovk@miss-islington
decimal docs: specification link and examples (pythonGH-128698)
86d8e33
(cherry picked from commit 2450be6)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@skirpichev@rruuaanng
@StanFromIreland@hugovk@miss-islington
decimal docs: specification link and examples (pythonGH-128698)
3a4b5b2
(cherry picked from commit 2450be6)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Dec 16, 2025

Copy link
Copy Markdown

GH-142804 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Dec 16, 2025
@bedevere-app

bedevere-appBot commented Dec 16, 2025

Copy link
Copy Markdown

GH-142805 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Dec 16, 2025
@skirpichev
skirpichev deleted the decimal-docs branch December 16, 2025 11:43
kumaraditya303 pushed a commit that referenced this pull request Dec 17, 2025
@miss-islington@skirpichev
@rruuaanng@StanFromIreland@hugovk
[3.14] decimal docs: specification link and examples (GH-128698) (#14…
ad6396e
…2804)
decimal docs: specification link and examples (GH-128698)
(cherry picked from commit 2450be6)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
kumaraditya303 pushed a commit that referenced this pull request Dec 17, 2025
@miss-islington@skirpichev
@rruuaanng@StanFromIreland@hugovk
[3.13] decimal docs: specification link and examples (GH-128698) (#14…
e5fd737
…2805)
decimal docs: specification link and examples (GH-128698)
(cherry picked from commit 2450be6)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments
@StanFromIrelandStanFromIrelandStanFromIreland approved these changes
@ericvsmithericvsmithAwaiting requested review from ericvsmith
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka
@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner
+1 more reviewer
@rruuaanngrruuaanngrruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@skirpichev@ericvsmith@hugovk@StanFromIreland@rruuaanng@serhiy-storchaka